From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aaron Conole Newsgroups: gmane.emacs.devel Subject: [PATCH] Call va_end after processing ap Date: Mon, 02 May 2016 15:39:26 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462218475 11611 80.91.229.3 (2 May 2016 19:47:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 May 2016 19:47:55 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 02 21:47:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1axJoq-0007QX-Fz for ged-emacs-devel@m.gmane.org; Mon, 02 May 2016 21:47:48 +0200 Original-Received: from localhost ([::1]:38307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axJoj-0006bF-9X for ged-emacs-devel@m.gmane.org; Mon, 02 May 2016 15:47:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axJoa-0006NN-HK for emacs-devel@gnu.org; Mon, 02 May 2016 15:47:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axJoO-0006u1-Vr for emacs-devel@gnu.org; Mon, 02 May 2016 15:47:27 -0400 Original-Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:34687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axJoN-0006pO-M6 for emacs-devel@gnu.org; Mon, 02 May 2016 15:47:20 -0400 Original-Received: by mail-qk0-x22a.google.com with SMTP id r184so79614177qkc.1 for ; Mon, 02 May 2016 12:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytheb-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:lines:user-agent:message-id:mime-version; bh=1Gv1MR2A1zQ5BhQWMLXPrxtUmOPjUeiXcG8EVCSytgc=; b=xOCagoHtpt7HYlUE+g+onXEXGibtd0pFgWOZceJB+sL2ajgLs3C5VzzIlDrBFralOB S3JbqLJCnHpayby5OS5RDkLac0jN/B599fv9ifJ/SnqfsZ1paicZuanTPnineK+sstW0 zDMC+h7uJIqSmHqnnJms4N4QSwnF4YprA1OHhhOjiS0o5OaVhbU18PqoPlqnGOHwV1lx ifVSlbPFa5AY6Adsfi6diFVIgVwnR6rnFCqsdSbCQ1LnKjCSnZ7VcU1ZhHGcVm0Vcsi5 2Lbui7xHSAlIdIIDXAD3vFlSAf8ah5vulDVjEE1vKX/N0KZfeqDYWj/LTfLMy/qCJ7oB 1NSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:lines:user-agent:message-id :mime-version; bh=1Gv1MR2A1zQ5BhQWMLXPrxtUmOPjUeiXcG8EVCSytgc=; b=k0Pw9Xe+3J4w3iaxNCHNN48c3WwrikAH5ImHSWbNZHLYRfSamjarzxuKAZ4dt1QD+m OHsnz1Vfk3As2nD7WFK1em3fFRIrw3yYJYcycPN/8H0bymlnTxZv1IPrcJRKDNXy0M0B ftha6thV8z+XoYtE0xA2/1Mk1TiLZ+anN1It42fjpoZIyY9/+6zMsgRpdPVYTdM4cH7U PwA+nosNWbB3wnlYMPLtxBlBaPsA1/VuR+msS0uGEeJNwla8gkBaR8d5cAVBovOZMyqq 72dPLpCNqdq/l19JXqfK/xaa0hHLlcrPuZWpc1jh5CXUwEyuGQS6B4j5RkAwvJjBQzS2 u6kA== X-Gm-Message-State: AOPr4FUs3QPmTTqJPCZRh1ies1W8ahC9TaEKNPbfstm/7Z6j1hF9YBcQx6Kwk2BdtS4efA== X-Received: by 10.55.15.81 with SMTP id z78mr18429374qkg.209.1462218419211; Mon, 02 May 2016 12:46:59 -0700 (PDT) Original-Received: from aconole-fed23 (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id v66sm9670102qka.14.2016.05.02.12.46.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 May 2016 12:46:58 -0700 (PDT) Original-Lines: 23 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-From-Line: nobody Mon May 2 15:39:28 2016 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203528 Archived-At: * gnutls.c (boot_error): A recent change added a function to signal an error or return an error code. That function uses a variadic argument list to populate an error message string. However, it missed calling va_end after using the variadic argument list. --- NOTE: I sent a copy of this from my work email (which isn't subscribed). Sorry if it is duplicated in the email system, but I didn't see it land so I'm resending. src/gnutls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gnutls.c b/src/gnutls.c index 57b164a..1089b1a 100644 --- a/src/gnutls.c +++ b/src/gnutls.c @@ -1181,6 +1181,7 @@ boot_error (struct Lisp_Process *p, const char *m, ...) pset_status (p, list2 (Qfailed, vformat_string (m, ap))); else verror (m, ap); + va_end(ap); } Lisp_Object -- 2.5.5