From: Drew Adams <drew.adams@oracle.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 25243@debbugs.gnu.org
Subject: bug#25243: 26.0.50; ffap-guesser very slow w/ region active in large diff files
Date: Thu, 22 Dec 2016 09:22:38 -0800 (PST) [thread overview]
Message-ID: <f7fca0cd-097f-4944-a7b3-74241d233588@default> (raw)
In-Reply-To: <87vauclh42.fsf@gmail.com>
Thanks for working on this, Tino. Some minor comments below.
> +(defvar ffap-max-region-length 1024
> + "Maximum allowed region length in `ffap-string-at-point'.")
1. I think it should say "active region".
Very minor (can be ignored): If we say something is not allowed it is
unclear what happens. In particular, it can suggest that we raise an
error. You might want to say here that if the active region is larger
... it is considered empty. (Or just refer to `ffap-string-at-point',
which you do already.)
> + (region-len (- (max beg end) (min beg end))))
> + (if (or (null ffap-max-region-length)
> + (< region-len ffap-max-region-length)) ; Bug#25243.
> + (setf ffap-string-at-point-region (list beg end)
> + ffap-string-at-point
> + (buffer-substring-no-properties beg end))
> + (setf ffap-string-at-point-region (list 1 1)
> + ffap-string-at-point ""))))
1. The doc string should say that if the active region is
larger than `ffap-max-region-length' then those two vars
are set to ... and ....
2. Instead of testing whether the max-length var is nil, I'd suggest
testing it with `natnump', to take care of the unexpected case where
it might get assigned a non-number.
next prev parent reply other threads:[~2016-12-22 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 15:35 bug#25243: 26.0.50; ffap-guesser very slow w/ region active in large diff files Tino Calancha
2016-12-21 16:22 ` Drew Adams
2016-12-22 4:31 ` Tino Calancha
2016-12-22 17:22 ` Drew Adams [this message]
2016-12-23 7:12 ` Tino Calancha
2016-12-23 15:41 ` Drew Adams
2016-12-24 2:53 ` Tino Calancha
2016-12-30 6:41 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7fca0cd-097f-4944-a7b3-74241d233588@default \
--to=drew.adams@oracle.com \
--cc=25243@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.