From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master 369cb30: (libxml-parse-html-region): Make DISCARD-COMMENTS obsolete Date: Mon, 23 Apr 2018 21:03:38 -0400 Message-ID: References: <20180414170725.23574.8815@vcs0.savannah.gnu.org> <20180414170726.9EBD720648@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524531703 3598 195.159.176.226 (24 Apr 2018 01:01:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 24 Apr 2018 01:01:43 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 24 03:01:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fAmKv-0000os-Kf for ged-emacs-devel@m.gmane.org; Tue, 24 Apr 2018 03:01:37 +0200 Original-Received: from localhost ([::1]:56010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAmN2-0003BF-Hy for ged-emacs-devel@m.gmane.org; Mon, 23 Apr 2018 21:03:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAmMu-00039i-0u for emacs-devel@gnu.org; Mon, 23 Apr 2018 21:03:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAmMt-0007wU-7e for emacs-devel@gnu.org; Mon, 23 Apr 2018 21:03:40 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAmMt-0007wQ-3n; Mon, 23 Apr 2018 21:03:39 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1fAmMs-0002gd-HQ; Mon, 23 Apr 2018 21:03:38 -0400 X-Spook: Nazi bootleg pre-emptive Response Domestic security JPL X-Ran: 46_%@G^|zD]kI57<5m"L7e~?ev'!.D)y6gAAoHvi@r!GDxT@498%~@]vL*SD*^13ot.>q| X-Hue: green X-Attribution: GM In-Reply-To: <20180414170726.9EBD720648@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 14 Apr 2018 13:07:26 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224820 Archived-At: Lars Ingebrigtsen wrote: > branch: master > commit 369cb30d8cc9b2c1eee8ed21cca89e0277f8d61d [...] > (libxml-parse-html-region): Make DISCARD-COMMENTS obsolete > > * lisp/subr.el (libxml-parse-xml-region) > (libxml-parse-html-region): Make DISCARD-COMMENTS obsolete. [...] > --- a/lisp/subr.el > +++ b/lisp/subr.el [...] > +(set-advertised-calling-convention 'libxml-parse-xml-region '(start end base-url) "27.1") > +(set-advertised-calling-convention 'libxml-parse-html-region '(start end base-url) "27.1") Hi, As well as making DISCARD-COMMENTS obsolete, the above makes BASE-URL required when it was previously optional. Was that intentional?