Scheme code evaluation in fresh Emacs

Scheme code evaluation in fresh Emacs

[Neil Jerram]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

When I try to evaluate Scheme code in an Emacs where I haven't yet done 
any Geiser/Scheme work, I get an error about 
geiser-default-implementation being undefined.  The attached patch fixes 
that, but I am not sure if it is the most minimal fix possible.  WDYT?

Best wishes - Neil



[-- Attachment #2: 0001-Fix-Scheme-evaluation-in-fresh-Emacs.patch --]
[-- Type: text/x-patch, Size: 951 bytes --]

From adceb034b886d1c3624b31f83f8826869cd1b92c Mon Sep 17 00:00:00 2001
From: Neil Jerram <neil@tigera.io>
Date: Tue, 19 Dec 2017 18:15:00 +0000
Subject: [PATCH] Fix Scheme evaluation in fresh Emacs

* lisp/ob-scheme.el: Require geiser-impl so that
  geiser-default-implementation is defined.  Otherwise, unless Geiser
  has previously been run (e.g. with `run-geiser'), you'll see an
  error that geiser-default-implementation is undefined.
---
 lisp/ob-scheme.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/ob-scheme.el b/lisp/ob-scheme.el
index f67080adf..7dbd78097 100644
--- a/lisp/ob-scheme.el
+++ b/lisp/ob-scheme.el
@@ -40,6 +40,7 @@
 ;;; Code:
 (require 'ob)
 (require 'geiser nil t)
+(require 'geiser-impl nil t)
 (defvar geiser-repl--repl)             ; Defined in geiser-repl.el
 (defvar geiser-impl--implementation)   ; Defined in geiser-impl.el
 (defvar geiser-default-implementation) ; Defined in geiser-impl.el
-- 
2.15.1

Re: Scheme code evaluation in fresh Emacs

[Nicolas Goaziou]

Hello,

Neil Jerram <neil@ossau.homelinux.net> writes:

> When I try to evaluate Scheme code in an Emacs where I haven't yet
> done any Geiser/Scheme work, I get an error about
> geiser-default-implementation being undefined.  The attached patch
> fixes that, but I am not sure if it is the most minimal fix possible. 
> WDYT?

Thank you. I applied the patch.

I think it would be worth notifying upstream about it, if you have some
spare time.

Regards,

-- 
Nicolas Goaziou

Re: Scheme code evaluation in fresh Emacs

[Neil Jerram]

On 19/12/17 19:30, Nicolas Goaziou wrote:
> Hello,
>
> Neil Jerram <neil@ossau.homelinux.net> writes:
>
>> When I try to evaluate Scheme code in an Emacs where I haven't yet
>> done any Geiser/Scheme work, I get an error about
>> geiser-default-implementation being undefined.  The attached patch
>> fixes that, but I am not sure if it is the most minimal fix possible.
>> WDYT?
> Thank you. I applied the patch.
>
> I think it would be worth notifying upstream about it, if you have some
> spare time.

Sure, but which upstream do you mean?

     Neil

Re: Scheme code evaluation in fresh Emacs

[Nicolas Goaziou]

Neil Jerram <neil@ossau.homelinux.net> writes:

> On 19/12/17 19:30, Nicolas Goaziou wrote:

>> I think it would be worth notifying upstream about it, if you have some
>> spare time.
>
> Sure, but which upstream do you mean?

Geiser. Maybe geiser-default-implementation should autoload geiser-impl
or some such.