From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Commit netiquette. Date: Thu, 18 Feb 2010 16:12:47 +0100 Message-ID: References: <87eikjzaug.fsf@telefonica.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1266506070 19227 80.91.229.12 (18 Feb 2010 15:14:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Feb 2010 15:14:30 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar_Fuentes?= , emacs-devel@gnu.org To: ams@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 18 16:14:27 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ni85D-0004Vk-8f for ged-emacs-devel@m.gmane.org; Thu, 18 Feb 2010 16:14:27 +0100 Original-Received: from localhost ([127.0.0.1]:33563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ni85C-0000lD-CR for ged-emacs-devel@m.gmane.org; Thu, 18 Feb 2010 10:14:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ni840-0000U3-Kp for emacs-devel@gnu.org; Thu, 18 Feb 2010 10:13:12 -0500 Original-Received: from [140.186.70.92] (port=54644 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ni83z-0000TG-Il for emacs-devel@gnu.org; Thu, 18 Feb 2010 10:13:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ni83y-0006iq-Mi for emacs-devel@gnu.org; Thu, 18 Feb 2010 10:13:11 -0500 Original-Received: from mail-bw0-f219.google.com ([209.85.218.219]:36946) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ni83y-0006iM-Fi; Thu, 18 Feb 2010 10:13:10 -0500 Original-Received: by bwz19 with SMTP id 19so235421bwz.26 for ; Thu, 18 Feb 2010 07:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=a8I17FialdNTKED0gw/h6Jo6a5YXZeTdPM1DarOSZOQ=; b=WbeTjR++lR5qY0eusiq+q3tU3la9Y5beOXW7hZGHsN3EG1J5Y9Ak1J1jNDknI4xeCI 5t9MsEJ/NUCDdAQlRb7S97BpwBHkxFtc7kndrdgvR8PMP2yZKhpbQn6OXg9DCWTrmoNk 6k+Sc23x4EJ9GKUKCK6PQNwSAd827DiLOPwUw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=oBmzq+M/aAAln+BxHGIbkA7S9qDkA5mL4qalaQRxrjO6y9Xte6mdj9vL7j1tKDtpVf jLgJ4HydmjOVrUdMvZrvWZjv1mJpCu91g3/RnlSjmcwcZSQq1nnRdmktkT9YSd9B++O4 Kw8mVBiDIn6DS+wG0S1s4EnV2whDJcqJv2ThY= Original-Received: by 10.204.1.132 with SMTP id 4mr651456bkf.29.1266505987532; Thu, 18 Feb 2010 07:13:07 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121191 Archived-At: On Thu, Feb 18, 2010 at 15:45, Alfred M. Szmidt wrote: > This seems more of a short comming in `bzr log --short' than in the > way one writes commit messages. =C2=A0A commit message is more than a > single line. =C2=A0And the purpose of a change is always more suitable in > the actual code as a comment. You're conflating quite different things. If I update my tree with "bzr up", obviously I'm not going to go looking at the code to know which changes were made, but I certainly will do "bzr log --line -l10" to see recent changes and their purpose. And it is ridiculous to say that it is a "shortcoming" of log --short. --short or --line are a convenience; making sure that the first line of the commit log summarizes the change is just being nice to fellow developers. You can always see the full log if you want; is not like following the recommendation somehow impedes you from writing as long a commit message as you want. We currently *have* policies about ChangeLog entries and commit logs, so I agree with =C3=93scar: it is a good practice and we should require people to follow it; and treat people who doesn't the same way we treat people who mangles ChangeLog entries (that is, a gentle but firm reminder that we have guideliness and we're all expected to follow them). Juanma