From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Next pretest Date: Wed, 27 Jan 2010 17:06:48 +0100 Message-ID: References: <87fx5vef1j.fsf@stupidchicken.com> <87sk9sga2k.fsf@stupidchicken.com> <83aaw068mj.fsf@gnu.org> <4B5F9ECB.1010601@gnu.org> <87aavz63x2.fsf@wanchan.jasonrumney.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1264608515 19882 80.91.229.12 (27 Jan 2010 16:08:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Jan 2010 16:08:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 27 17:08:31 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NaARS-0002oL-92 for ged-emacs-devel@m.gmane.org; Wed, 27 Jan 2010 17:08:30 +0100 Original-Received: from localhost ([127.0.0.1]:49831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaARP-0003oZ-Kb for ged-emacs-devel@m.gmane.org; Wed, 27 Jan 2010 11:08:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NaARK-0003n2-Ax for emacs-devel@gnu.org; Wed, 27 Jan 2010 11:08:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NaARF-0003gD-If for emacs-devel@gnu.org; Wed, 27 Jan 2010 11:08:21 -0500 Original-Received: from [199.232.76.173] (port=45815 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaARF-0003g4-FP for emacs-devel@gnu.org; Wed, 27 Jan 2010 11:08:17 -0500 Original-Received: from mail-bw0-f219.google.com ([209.85.218.219]:55726) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NaARD-0007ML-81; Wed, 27 Jan 2010 11:08:15 -0500 Original-Received: by bwz19 with SMTP id 19so4886688bwz.8 for ; Wed, 27 Jan 2010 08:08:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=UdGxXeMSvNy+uS5z9DNNVMH62KTY2NAiJiXpfnUtAtA=; b=Tm7hG3Y3meDpGDDFHQGKOy0236RyJSIbrTj9pBVH5m2+n3VLKwO8uj3PRfw4MYaHaH xdmNHxYZnILuy/62cHoDtHY57mgGIvFRelnrfPHmVNMoJD7oosfOI6x0AO5qfmJQ6i2V AFuMwRvPKE34qlFlVxiakzn9ah2miYOwJyuuY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=ld/oxdwTZ/nvtQxJq+ppkGRWSNThj1p0o87wDhg2SZy6F6u6Le/CGIia9koD1Lx2DV G5rCM+Le6viEHb3p9qU8p9ez+SADIaK2B4R1TcclgiVqxg3I4XAvQNPq8qdU0yXYKeS6 geDQQzvcf3ayemSyeCelaJjp53rdbjXTaWBck= Original-Received: by 10.204.13.202 with SMTP id d10mr1891767bka.85.1264608493771; Wed, 27 Jan 2010 08:08:13 -0800 (PST) In-Reply-To: <87aavz63x2.fsf@wanchan.jasonrumney.net> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120514 Archived-At: On Wed, Jan 27, 2010 at 15:03, Jason Rumney wrote: > Please try the following patch: (I've changed three trivial typos emacs_ev. to emacs_ev->) It still triggers the assertion, and kind is still ASCII_KEYSTROKE_EVENT: keyboard.c:5614: Emacs fatal error: assertion failed: c =3D=3D event->cod= e Breakpoint 1, w32_abort () at w32fns.c:7345 7345 button =3D MessageBox (NULL, (gdb) bt #0 w32_abort () at w32fns.c:7345 #1 0x0104f358 in die (msg=3D0x1548e80 "assertion failed: c =3D=3D event->code", file=3D0x15404e0 "keyboard.c", line=3D5614) at alloc.c:6259 #2 0x010135f6 in make_lispy_event (event=3D0x167f178) at keyboard.c:5614 #3 0x010117e7 in kbd_buffer_get_event (kbp=3D0x88f828, used_mouse_menu=3D0x88fabc, end_time=3D0x0) at keyboard.c:4347 #4 0x0100d899 in read_char (commandflag=3D1, nmaps=3D2, maps=3D0x88f960, prev_event=3D48322562, used_mouse_menu=3D0x88fabc, end_time=3D0x0) at keyboard.c:3079 #5 0x0101f75f in read_key_sequence (keybuf=3D0x88fc00, bufsize=3D30, prompt=3D48322562, dont_downcase_last=3D0, can_return_switch_frame=3D1, fix_current_buffer=3D1) at keyboard.c:9512 #6 0x01007c86 in command_loop_1 () at keyboard.c:1643 #7 0x0103bb12 in internal_condition_case (bfun=3D0x10073e0 , handlers=3D48379098, hfun=3D0x1006b11 ) at eval.c:1490 #8 0x01006feb in command_loop_2 () at keyboard.c:1360 #9 0x0103b531 in internal_catch (tag=3D48378290, func=3D0x1006fc8 , arg=3D48322562) at eval.c:1226 #10 0x01006fa1 in command_loop () at keyboard.c:1339 #11 0x01006203 in recursive_edit_1 () at keyboard.c:954 #12 0x01006727 in Frecursive_edit () at keyboard.c:1016 #13 0x01002af2 in main (argc=3D3, argv=3D0xa71318) at emacs.c:1833 (gdb) frame 2 #2 0x010135f6 in make_lispy_event (event=3D0x167f178) at keyboard.c:5614 5614 eassert (c =3D=3D event->code); (gdb) p *event $1 =3D { kind =3D ASCII_KEYSTROKE_EVENT, code =3D -92, part =3D scroll_bar_above_handle, modifiers =3D 0, x =3D 0, y =3D 0, timestamp =3D 25781364, padding =3D {0x0, 0x0}, frame_or_window =3D 48446469, arg =3D 48322562 } In key_event, control is going through this branch else if (event->uChar.AsciiChar < 128) { emacs_ev->kind =3D ASCII_KEYSTROKE_EVENT; emacs_ev->code =3D event->uChar.AsciiChar; } (that's lines 473-477 after your patch) because at that point, event is (gdb) p *event $3 =3D { bKeyDown =3D 1, wRepeatCount =3D 1, wVirtualKeyCode =3D 192, wVirtualScanCode =3D 39, uChar =3D { UnicodeChar =3D 164 L'=C2=A4\000', AsciiChar =3D -92 '=C2=A4' }, dwControlKeyState =3D 0 } Juanma