From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: commit style redux Date: Sat, 16 Jan 2010 08:03:08 +0100 Message-ID: References: <3a26oiti.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1263625431 14472 80.91.229.12 (16 Jan 2010 07:03:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jan 2010 07:03:51 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 16 08:03:43 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NW2hD-0001mp-Ix for ged-emacs-devel@m.gmane.org; Sat, 16 Jan 2010 08:03:43 +0100 Original-Received: from localhost ([127.0.0.1]:56995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NW2hE-0007xs-Ij for ged-emacs-devel@m.gmane.org; Sat, 16 Jan 2010 02:03:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NW2h9-0007xW-Qj for emacs-devel@gnu.org; Sat, 16 Jan 2010 02:03:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NW2h5-0007wn-At for emacs-devel@gnu.org; Sat, 16 Jan 2010 02:03:39 -0500 Original-Received: from [199.232.76.173] (port=49470 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NW2h5-0007wk-8A for emacs-devel@gnu.org; Sat, 16 Jan 2010 02:03:35 -0500 Original-Received: from mail-bw0-f215.google.com ([209.85.218.215]:47794) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NW2h2-0004xX-Jh; Sat, 16 Jan 2010 02:03:32 -0500 Original-Received: by bwz7 with SMTP id 7so1177238bwz.26 for ; Fri, 15 Jan 2010 23:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=Se3yBbKXYBXiIrk/crwZ/kmnXcFrNowtNSvqJLpknzs=; b=nG7OdJdyOfq6TQxsj4tLT+Vg0nztJmwqnPqyHR5BFbr+ImEZGfG1a8/2Xt4A5uzGWt fF6xJrcyoR7rLUTE5xUz8aFXHQnl0wwc7/PNu9PsuGjmoIChiGN2W4JbLRXNY10RCPE4 /+rw4pA6KnwsrjRinn9vPEl7EMn/PqFywld4g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=oWApWVaOfBdiOggxHaaNRjTdxwN9jLmbvaW+cfXKZ4D+3QzLzExgJteRBUqxUqR7Xz zHw7VcXgdPyGyiQv30ljNY3xukuhgfvINtKxb2DBLOYn4Y0mcMgJcQ6Uw7TU6qc4Kpae 2fcyT2qNo1ZipyQGYSvDAGlL/jsGywkA6M4+c= Original-Received: by 10.204.36.199 with SMTP id u7mr1841206bkd.212.1263625408159; Fri, 15 Jan 2010 23:03:28 -0800 (PST) In-Reply-To: <3a26oiti.fsf@fencepost.gnu.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120087 Archived-At: On Sat, Jan 16, 2010 at 04:00, Glenn Morris wrote: > The paths are relative to where each ChangeLog file is, rather than > relative to the root of the project. If there are two files with the > same basename in different subdirectories, things might get ambiguous. There aren't that many matching filenames, and in most cases it should be obvious from the change which file it is affecting, I think. BTW, perhaps we should clean the dust from Miles message and use it as the start of a "commit policy" document. For example, the point about the SHORTISH ONE-LINE SUMMARY should be stressed IMHO; it is really quite useful when browsing commits. Another thing we still do quite often is mixing trivial, unrelated fixes in a single commit (for example, uncountable times I've fixed typos, etc. in a ChangeLog at the same time that I was adding an entry to that ChangeLog). We should try to get used to separate these kinds of changes even if it means a bit more work (alas, that's much easier with interactive cherry-picking tools, like git add -i, which I think Bazaar lacks). Juanma