From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#5313: editing files in hexl-mode corrupts file Date: Thu, 14 Jan 2010 01:50:34 +0100 Message-ID: References: <645d17211001040535n2ad649b8l7de0e48a0873b7f8@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1263431995 6716 80.91.229.12 (14 Jan 2010 01:19:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Jan 2010 01:19:55 +0000 (UTC) Cc: 5313@debbugs.gnu.org To: Jonathan Underwood Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 14 02:19:47 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NVENH-0001QD-2s for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jan 2010 02:19:47 +0100 Original-Received: from localhost ([127.0.0.1]:53742 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVENH-0005BL-OF for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jan 2010 20:19:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVEN0-0004tt-JD for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2010 20:19:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVEMv-0004kM-O3 for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2010 20:19:30 -0500 Original-Received: from [199.232.76.173] (port=33058 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVEMv-0004k3-IK for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2010 20:19:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34465) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NVEMv-0007bz-90 for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2010 20:19:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NVDvU-00053t-1I; Wed, 13 Jan 2010 19:51:04 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jan 2010 00:51:03 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5313 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5313-submit@debbugs.gnu.org id=B5313.126343026319442 (code B ref 5313); Thu, 14 Jan 2010 00:51:03 +0000 Original-Received: (at 5313) by debbugs.gnu.org; 14 Jan 2010 00:51:03 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NVDvR-00053T-2n for submit@debbugs.gnu.org; Wed, 13 Jan 2010 19:51:01 -0500 Original-Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NVDvO-00053M-Tv for 5313@debbugs.gnu.org; Wed, 13 Jan 2010 19:50:59 -0500 Original-Received: by bwz8 with SMTP id 8so16159490bwz.39 for <5313@debbugs.gnu.org>; Wed, 13 Jan 2010 16:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=j/jUOVzYKvRwwBCmn2z54oVzmy+zU/OqKsvXy6uSyUc=; b=ShxEbFmdGGk7M/+tVsk7P3QO4HJ3JBVqwoiaAgw3ex8Ju5Yyfo2tA/zo3UJw4AbaP1 H18UZu4DtwTLNQcwFD/ya528J6xjDLt5rOK0VCObRlfgze7Cm8LERGcFBPRwnJACcCjO jIbOKAmMnNeTA38+Jn6gSHD43AaxsZO0gEUf4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=e/lRpHXOhxWOgvDzgSoaG317yFtHgVGb+dLvOxouUFe8PkMggNa6LGusWTllbqXBV1 ikue+oRgY7pZonm93N4sG9uaALEoJLR3e1OSBaBOXrA0w2bJip2V+S6Q5JlxbEL29+Vt 6iH6ue1GLD3xN4hrXTs7Q2IQOJV3iEO1NEBg0= Original-Received: by 10.204.6.5 with SMTP id 5mr15483bkx.167.1263430254232; Wed, 13 Jan 2010 16:50:54 -0800 (PST) In-Reply-To: <645d17211001040535n2ad649b8l7de0e48a0873b7f8@mail.gmail.com> X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.8 (--) Resent-Date: Wed, 13 Jan 2010 19:51:04 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34304 Archived-At: On Mon, Jan 4, 2010 at 14:35, Jonathan Underwood wrote: > A bug report was filed downstream about hexl-mode corrupting a file > during editing: > > https://bugzilla.redhat.com/show_bug.cgi?id=547566 Could you please try the following patch? Juanma === modified file 'lisp/hexl.el' --- lisp/hexl.el 2010-01-13 08:35:10 +0000 +++ lisp/hexl.el 2010-01-14 00:38:04 +0000 @@ -779,7 +779,7 @@ (defun hexl-printable-character (ch) "Return a displayable string for character CH." - (format "%c" (if hexl-iso + (format "%c" (if (not (equal hexl-iso "")) (if (or (< ch 32) (and (>= ch 127) (< ch 160))) 46 ch)