From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#5345: Password asked when visiting a file in a lightweight checkout Date: Sat, 9 Jan 2010 21:08:58 +0100 Message-ID: References: <87eilzio5b.fsf@gmx.de> <83vdfb8jxa.fsf@gnu.org> <201001091846.o09Ikv1G009474@godzilla.ics.uci.edu> <201001091920.o09JKqPp010697@godzilla.ics.uci.edu> Reply-To: Juanma Barranquero , 5345@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1263068388 4734 80.91.229.12 (9 Jan 2010 20:19:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Jan 2010 20:19:48 +0000 (UTC) Cc: 5345@debbugs.gnu.org To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 09 21:19:41 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NThmd-0000mR-8j for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jan 2010 21:19:39 +0100 Original-Received: from localhost ([127.0.0.1]:49001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NThmd-00047H-Pf for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jan 2010 15:19:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NThmK-0003tO-Qf for bug-gnu-emacs@gnu.org; Sat, 09 Jan 2010 15:19:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NThmG-0003qL-7J for bug-gnu-emacs@gnu.org; Sat, 09 Jan 2010 15:19:20 -0500 Original-Received: from [199.232.76.173] (port=55044 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NThmF-0003qD-Pk for bug-gnu-emacs@gnu.org; Sat, 09 Jan 2010 15:19:15 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33849) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NThmF-00073Y-FR for bug-gnu-emacs@gnu.org; Sat, 09 Jan 2010 15:19:15 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NThdL-0004ZY-4f; Sat, 09 Jan 2010 15:10:03 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Juanma Barranquero , 5345@debbugs.gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jan 2010 20:10:03 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5345 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5345-submit@debbugs.gnu.org id=B5345.126306776617560 (code B ref 5345); Sat, 09 Jan 2010 20:10:03 +0000 Original-Received: (at 5345) by debbugs.gnu.org; 9 Jan 2010 20:09:26 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NThcj-0004ZB-Jg for submit@debbugs.gnu.org; Sat, 09 Jan 2010 15:09:25 -0500 Original-Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NThci-0004Z4-13 for 5345@debbugs.gnu.org; Sat, 09 Jan 2010 15:09:24 -0500 Original-Received: by bwz8 with SMTP id 8so13140122bwz.39 for <5345@debbugs.gnu.org>; Sat, 09 Jan 2010 12:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=bSRy0zhUY9D83ivIXWX8+rkt7uWSNEDO4YNCHczkVMI=; b=mM51KFtCKulrDUkkpfaA0lj2RVcBgBNTc8t2+zrhEqeHhSWIxSUeiRovASjWoMTxmn Zbg65oZ3C16X+w5+WrXtOUTLNlubU80mnVEHHcdxLLW4zBXHja82/YiE/ZWPje893jYZ fGpPtDZqlh5B7ss6uSueU7SlShO1MsayuaiE0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=tghcN95fd1LhkNL6tinmOFls3DiiF8ZUW+VCttU3P6UbFbDLnElYWqNVtJdNeQZB74 vPCGQFf4vHNllJEoO7gJTwgp4z4srqzw5pKdLmm1pJ3YkO5GvX/e5uwG/kYKMhWR4ZZ0 qTJI9BolhEYpGkrv+h6fRoTuYn44z6e9j6i1s= Original-Received: by 10.204.154.91 with SMTP id n27mr3079730bkw.147.1263067758266; Sat, 09 Jan 2010 12:09:18 -0800 (PST) In-Reply-To: <201001091920.o09JKqPp010697@godzilla.ics.uci.edu> X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.7 (--) Resent-Date: Sat, 09 Jan 2010 15:10:03 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34127 Archived-At: On Sat, Jan 9, 2010 at 20:20, Dan Nicolaescu wrote: > Is that the correct URL syntax? Yes. This kind of URL is very common when dealing with files on Windows. According to RFC 1738 ("Uniform Resource Locators (URL)"), section 3.10 ("FILES"), the syntax is file:/// i.e., the slashes are separators. And "[a]s a special case, can be the string "localhost" or the empty string; this is interpreted as `the machine from which the URL is being interpreted'.". So file:///C:/path is a perfectly valid URL for a local file on Windows, as a shorthand for file://localhost/C:/path. I'm surprised Unix URLs for absolute paths do not start with file:////. > But please do it with a system-type test, /C:/emacs/repo/bugs/5313/ is a > valid unix file name. =C2=A0Probably not used too much, but valid, so it > should not be excluded. Are you OK with the following patch? Juanma =3D=3D=3D modified file 'lisp/vc-bzr.el' --- lisp/vc-bzr.el 2010-01-06 15:11:52 +0000 +++ lisp/vc-bzr.el 2010-01-09 20:06:10 +0000 @@ -361,6 +361,11 @@ ;; look there for the version information. (when (re-search-forward "file://\\(.+\\)" nil t) (let ((l-c-parent-dir (match-string 1))) + (when (and (memq system-type '(ms-dos windows-nt)) + (string-match-p "^/[[:alpha:]]:" l-c-parent-dir)) + ;;; On Windows, file:// URLs often have three slashes, + ;;; so we must remove the remaining one (bug#5345) + (setq l-c-parent-dir (substring l-c-parent-dir 1))) (setq branch-format-file (expand-file-name vc-bzr-admin-branch-format-file l-c-parent-dir))