From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#5294: 23.1; unload-feature disable minor-mode Date: Wed, 6 Jan 2010 02:09:10 +0100 Message-ID: References: <87aawwp631.fsf@blah.blah> <87tyv4njo7.fsf@blah.blah> <87bpha7ptb.fsf@blah.blah> <87iqbgt9h4.fsf@blah.blah> <87zl4srqr3.fsf@blah.blah> Reply-To: Juanma Barranquero , 5294@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1262744311 968 80.91.229.12 (6 Jan 2010 02:18:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2010 02:18:31 +0000 (UTC) Cc: 5294@debbugs.gnu.org To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 06 03:18:23 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NSLTb-0003zK-Cc for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Jan 2010 03:18:23 +0100 Original-Received: from localhost ([127.0.0.1]:48331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSLTb-0003Hu-SU for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Jan 2010 21:18:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSKY0-0006Fg-9T for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 20:18:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSKXv-0006BP-EI for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 20:18:51 -0500 Original-Received: from [199.232.76.173] (port=36462 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSKXv-0006BH-8f for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 20:18:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40802) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSKXu-00077D-VL for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 20:18:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NSKPU-0003w5-F2; Tue, 05 Jan 2010 20:10:04 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Juanma Barranquero , 5294@debbugs.gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jan 2010 01:10:04 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5294 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5294-submit@debbugs.gnu.org id=B5294.126274017715105 (code B ref 5294); Wed, 06 Jan 2010 01:10:04 +0000 Original-Received: (at 5294) by debbugs.gnu.org; 6 Jan 2010 01:09:37 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSKP2-0003va-QL for submit@debbugs.gnu.org; Tue, 05 Jan 2010 20:09:36 -0500 Original-Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSKP0-0003vR-Jt for 5294@debbugs.gnu.org; Tue, 05 Jan 2010 20:09:35 -0500 Original-Received: by bwz8 with SMTP id 8so10787409bwz.39 for <5294@debbugs.gnu.org>; Tue, 05 Jan 2010 17:09:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=HIlv5qbzWAxx+LjUJhVmwYcCpYKlYb4tq/lrt4hViMk=; b=EwYoJAEgFCkv4NG4VQ4a0dXWIbF6qtK+WW6NLpw7TbHjjpRMg1PumjleqQTVGGGXkQ 2kXBVwtF8Nm/WgWiNLId3HPQHdcc9YQkawGA2A8fzth4SjxkRl83QXKGani+p3p0MyEc a/XDLfOlstnKADr2fnwLUFTiLTwh1yD6QWPz8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=oZ9yG6vDFRNIPb74ycmXSeKGydmPe4KY4lMHqxNvneElDygKkIvKKmO4l2DZ9+pbLc JAo+lRhkgJB8A92l0Or9n9n3QvecKigknl3P2/bOtdhE/vDCBgPVkZJSAEsDQR2f/EWm oOpliT65uuWnp6Q/mZXZTfz6M0uy8eJBCIvCI= Original-Received: by 10.204.32.131 with SMTP id c3mr2107728bkd.190.1262740170207; Tue, 05 Jan 2010 17:09:30 -0800 (PST) In-Reply-To: <87zl4srqr3.fsf@blah.blah> X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.6 (--) Resent-Date: Tue, 05 Jan 2010 20:10:04 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33976 Archived-At: On Wed, Jan 6, 2010 at 02:01, Kevin Ryde wrote: > Principally that define-minor-mode knows what things it did and > therefore should be undone, or why they might not be undone at the > present time. But that is defined in the same file as the unload-function... > I think it would be rather repetitive to be obliged to > write a FOO-unload-function whenever making a minor mode. You want to write the same code, but put it in define-minor-mode. I don't think define-minor-mode should worry itself with unloading. > Which, err, presumes that there may be standardized things that should > be considered and/or undone for unloading a mode. =C2=A0I see you say the= re's > normally not -- where I say there could be a disable or a caution to > avoid likely breakage, removal from the minor modes menu, etc. I do not say that there are not, I say that they are not easy to generalize. Some are. For example, removing a minor-mode for the minor-modes menu seems a good idea, and should be done by unload-feature if it is not done already, because calling a nonexistent function is an error. Juanma