From: Juanma Barranquero <lekktu@gmail.com>
To: Kevin Ryde <user42@zip.com.au>
Cc: 5294@debbugs.gnu.org
Subject: bug#5294: 23.1; unload-feature disable minor-mode
Date: Sun, 3 Jan 2010 01:24:58 +0100 [thread overview]
Message-ID: <f7ccd24b1001021624l3e1e9d70gd72263e068d6bbc5@mail.gmail.com> (raw)
In-Reply-To: <87tyv4njo7.fsf@blah.blah>
On Sun, Jan 3, 2010 at 00:58, Kevin Ryde <user42@zip.com.au> wrote:
> It seems unlikely a minor mode can do anything much good when its
> functions have been unloaded. Some "static" effects might be ok,
That is the point. The writer of the mode knows better. I'm not saying
that you're not right in this, only that there could be downsides.
>> FOO-unload-hook is
>
> ... a flexible way for unrelated libraries, macros or bits of code to
> undo things they know about, even different conditionalized parts of one
> .el like in tramp-util.el.
Yeah, well, that and also, it never really worked. You seem to think
that FOO-unload-hook is a hook run while executing `unload-feature'.
In fact, is a hook run *instead* of some other code. The very act of
defining FOO-unload-hook has unexpected consequences: `unlead-feature'
won't remove FOO functions from hooks, nor from `auto-mode-alist'. And
it was always so; that's why I pushed for introducing
FOO-unload-function.
> A kind of inverse to eval-after-load,
> difficult to arrange on a monolithic unload func.
In general, a package is the place where the knowledge about its
unloading should be concentrated, IMO. If you want to piggyback onto
it, there are several ways, like advising FOO-unload-function, if it
is defined, or `unload-feature', etc. There's nothing "difficult to
arrange".
If you want to have an inverse to eval-after-load, I'd suggest you
propose a new hook, unload-feature-functions (not FOO-specific).
Juanma
next prev parent reply other threads:[~2010-01-03 0:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 21:09 bug#5294: 23.1; unload-feature disable minor-mode Kevin Ryde
2010-01-02 23:22 ` Juanma Barranquero
2010-01-02 23:58 ` Kevin Ryde
2010-01-03 0:24 ` Juanma Barranquero [this message]
2010-01-03 1:05 ` Kevin Ryde
2010-01-03 1:41 ` Juanma Barranquero
2010-01-03 23:04 ` Kevin Ryde
2010-01-03 23:12 ` Juanma Barranquero
2010-01-05 23:31 ` Kevin Ryde
2010-01-06 0:23 ` Juanma Barranquero
2010-01-06 1:01 ` Kevin Ryde
2010-01-06 1:09 ` Juanma Barranquero
2022-02-13 10:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b1001021624l3e1e9d70gd72263e068d6bbc5@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=5294@debbugs.gnu.org \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.