all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: ignoring autoloads in preloaded files on Windows
Date: Sat, 10 Oct 2009 07:13:28 +0200	[thread overview]
Message-ID: <f7ccd24b0910092213i526aeb84xeb4e803a803fa132@mail.gmail.com> (raw)
In-Reply-To: <f7ccd24b0910092117w626841b3o61fb16233ca93138@mail.gmail.com>

On Sat, Oct 10, 2009 at 06:17, Juanma Barranquero <lekktu@gmail.com> wrote:

> Aha. I think you're generating echolisp.tmp in the root, instead of
> lib-src/.

Wrong, wrong, wrong!

> If I move it to source and regenerate the autoloads, I see
> "skipped" indeed:

That's true indeed.

The real problem is that, in

  (when (ignore-errors
          (delete-file tmpfile)
          (shell-command (format "make -C %s echolisp > %s"
                                 mdir tmpfile))
          (file-readable-p tmpfile))
     ...)

`delete-file' has to be inside its own (ignore-errors); otherwise,
executing the function when there's no echolisp.tmp will skip the make
generation altogether. This is why copying a fresh echolisp.tmp to
lib-src worked.

Changing the code to

(when (ignore-errors
        (ignore-errors (delete-file tmpfile))
        (shell-command (format "make -C %s echolisp > %s"
                               mdir tmpfile))
        (file-readable-p tmpfile))

works, both bootstrapping and doing "make autoloads".

That said, right now loaddefs.el is 27241 bytes shorter than before,
or 97,76% of what used to be. Not much of a gain.

    Juanma




  parent reply	other threads:[~2009-10-10  5:13 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Mv3iq-0005oI-5L@monty-python.gnu.org>
2009-10-06  7:44 ` Changes in lisp/Makefile.in to skip preloaded files Eli Zaretskii
2009-10-06  9:25   ` Eli Zaretskii
2009-10-06  9:33     ` Miles Bader
2009-10-06  9:42       ` Eli Zaretskii
2009-10-06 10:14         ` Miles Bader
2009-10-06 13:12           ` Dan Nicolaescu
2009-10-06 13:45             ` Dan Nicolaescu
2009-10-06 16:20             ` Glenn Morris
2009-10-06 16:50               ` Dan Nicolaescu
2009-10-06 15:28     ` Stefan Monnier
2009-10-06 16:16     ` Glenn Morris
2009-10-06 18:41       ` Eli Zaretskii
2009-10-07  3:00         ` Glenn Morris
2009-10-07  7:23           ` Glenn Morris
2009-10-07  9:23             ` Eli Zaretskii
2009-10-07 10:00               ` Juanma Barranquero
2009-10-07 16:16               ` Glenn Morris
2009-10-08 23:08                 ` Lennart Borgman
2009-10-08 23:31                   ` Juanma Barranquero
2009-10-08 23:34                     ` Lennart Borgman
2009-10-09  0:02                       ` Juanma Barranquero
2009-10-09  0:04                         ` Glenn Morris
2009-10-09  0:25                           ` Juanma Barranquero
2009-10-09 11:48                             ` Lennart Borgman
2009-10-10  0:50                 ` ignoring autoloads in preloaded files on Windows [was Re: Changes in lisp/Makefile.in to skip preloaded files] Glenn Morris
2009-10-10  2:27                   ` Juanma Barranquero
2009-10-10  3:34                     ` ignoring autoloads in preloaded files on Windows Glenn Morris
2009-10-10  3:57                       ` Juanma Barranquero
2009-10-10  4:17                         ` Juanma Barranquero
2009-10-10  4:19                           ` Juanma Barranquero
2009-10-10  5:13                           ` Juanma Barranquero [this message]
2009-10-10  7:37                             ` Eli Zaretskii
2009-10-13 19:16                               ` Stefan Monnier
2009-10-15  6:14                                 ` Glenn Morris
2009-10-10  7:32                         ` Eli Zaretskii
2009-10-10 11:51                           ` Juanma Barranquero
2009-10-10 13:16                             ` Eli Zaretskii
2009-10-10 21:17                               ` Glenn Morris
2009-10-11  2:02                                 ` Juanma Barranquero
2009-10-11  2:36                                   ` Glenn Morris
2009-10-11  2:44                                     ` Glenn Morris
2009-10-11  3:35                                     ` Juanma Barranquero
2009-10-11 14:04                                       ` Juanma Barranquero
2009-10-07  9:57             ` Changes in lisp/Makefile.in to skip preloaded files Eli Zaretskii
2009-10-07  9:15           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0910092213i526aeb84xeb4e803a803fa132@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.