From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: delete-windows-on Date: Fri, 2 Oct 2009 18:51:54 +0200 Message-ID: References: <8EA9172832C04915909AE7B506260481@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1254502349 1951 80.91.229.12 (2 Oct 2009 16:52:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Oct 2009 16:52:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 02 18:52:22 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MtlMj-0008DX-K7 for ged-emacs-devel@m.gmane.org; Fri, 02 Oct 2009 18:52:21 +0200 Original-Received: from localhost ([127.0.0.1]:59711 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtlMj-0001BT-44 for ged-emacs-devel@m.gmane.org; Fri, 02 Oct 2009 12:52:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtlMe-0001B6-CZ for emacs-devel@gnu.org; Fri, 02 Oct 2009 12:52:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtlMd-0001Au-Tu for emacs-devel@gnu.org; Fri, 02 Oct 2009 12:52:16 -0400 Original-Received: from [199.232.76.173] (port=36308 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtlMd-0001Ar-Qf for emacs-devel@gnu.org; Fri, 02 Oct 2009 12:52:15 -0400 Original-Received: from fg-out-1718.google.com ([72.14.220.155]:5229) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtlMd-0000yH-D9 for emacs-devel@gnu.org; Fri, 02 Oct 2009 12:52:15 -0400 Original-Received: by fg-out-1718.google.com with SMTP id e21so1978976fga.12 for ; Fri, 02 Oct 2009 09:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=XIbMu3Nnc4aEEd1yaCKtY+r6z7iLCdVdi65BhtSez1Q=; b=xF7o++rxfOVJUWI8amlJZJwYGCbBjfNn/G67iU3Br+wHNE23W17p2wcDJHqAlDn6xc mYkFq6q9Rs5/PX52OSIS9M/DMqxJPOwI872n/E1R455Th/t7e74AB6lPF8k1Bit2av/s jig8urW+hmjQmOUHUEF4m20sdzEBSRJVbmkCM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=UNU++cL6BG92sEeva51F6HCHoHD/9QH1DXKseiAWpE/WOeSVDGR0fas2apqWryr6nA SlAUOU/dpQObypbfZi4AQ/ugls08Z8fcYN5qKPCX/o/IAncKverGbAYDivzFGPSlhtzc qXehnIR8OQWLCPGIHBoz9Ei2V+ruPnYSltwDE= Original-Received: by 10.239.130.30 with SMTP id 30mr280184hbh.130.1254502334132; Fri, 02 Oct 2009 09:52:14 -0700 (PDT) In-Reply-To: <8EA9172832C04915909AE7B506260481@us.oracle.com> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115851 Archived-At: On Fri, Oct 2, 2009 at 18:47, Drew Adams wrote: > 1. What "default buffer"? No such default is defined/implemented here, AFAICT. My mistake. s/default/current/ > 2. Besides, it is not the purpose of `delete-windows-on' to determine whether > the BUFFER arg in fact corresponds to an existing buffer or someone just fucked > up. Its purpose is to delete a window (or do nothing). No. Its purpose is to "[d]elete all windows showing BUFFER-OR-NAME." An incorrect BUFFER-OR-NAME is an error. > a. What to return, and whether the return value is significant (hence > documented) or the function is instead called only for its side effect. In general, I prefer functions that clearly state what do they return, even if it is always nil. > b. What to do when BUFFER does not represent a buffer. Raise an error? Do > nothing? Raise an error, IMHO. > Whatever choice is made, the documentation should reflect it. I agree. > Please read the entire mail I sent. Unnecessary. The fact that I only answer about *one* point of your message does not mean that I didn't read or understood the rest. It just means that I was interested in addressing just *one* point of your message. Juanma