From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#4534: assertion failure at window.c:grow_mini_window Date: Fri, 25 Sep 2009 13:30:38 +0200 Message-ID: References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <831vlvv2u8.fsf@gnu.org> Reply-To: Juanma Barranquero , 4534@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1253879251 25526 80.91.229.12 (25 Sep 2009 11:47:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Sep 2009 11:47:31 +0000 (UTC) Cc: 4534@emacsbugs.donarmstrong.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 25 13:47:23 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mr9Gk-00049P-C8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Sep 2009 13:47:22 +0200 Original-Received: from localhost ([127.0.0.1]:36198 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mr9Gj-0002Qa-In for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Sep 2009 07:47:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mr9Gd-0002Q0-Jn for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 07:47:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mr9GW-0002Ln-QK for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 07:47:13 -0400 Original-Received: from [199.232.76.173] (port=49916 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mr9GW-0002Ld-HI for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 07:47:08 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41723) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mr9GV-0008WG-JH for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 07:47:08 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PBl4Hu009716; Fri, 25 Sep 2009 04:47:05 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8PBe6Ot008681; Fri, 25 Sep 2009 04:40:06 -0700 Resent-Date: Fri, 25 Sep 2009 04:40:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juanma Barranquero Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 25 Sep 2009 11:40:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4534 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4534-submit@emacsbugs.donarmstrong.com id=B4534.12538782667622 (code B ref 4534); Fri, 25 Sep 2009 11:40:06 +0000 Original-Received: (at 4534) by emacsbugs.donarmstrong.com; 25 Sep 2009 11:31:06 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PBV4Ln007617 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 04:31:05 -0700 Original-Received: by fxm3 with SMTP id 3so2108541fxm.44 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 04:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=TN/oj2zJ5wtZiip/KyjRozQn5lmZGtJFmDgsPXxleEo=; b=DAh0UeLUTwR8vTLjNfxqRz0buN9b4LN4US+Grlk3bj+UOGkEO4tEPIxJY1op3R7VmT L4I7npnmkZh3xhIZY+W/1dtQqenm73jZhsXdltahKBLO5l23G9//2iBJDCz5BHpw+POj hDVMaX0/XUy6j89CsRPjnHTq5BP75k7xiH9xE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=TNb+f4Jv/q/PVPXwZ0RMgbKFpgBCUY6SKS0VaVKbLk7phqZ3a0bjwmP3vdUWURHnbB y2IfyCqVtZYuFWTUULiUgpPRRLBda9+PyanbVmgHiVVClbO4GIAwQtFYfaKAaUemNHkP dcDfbuSRLoHKVPqMa8mSG45IQEttj6h0zaFg0= Original-Received: by 10.239.144.90 with SMTP id n26mr1859hba.133.1253878258261; Fri, 25 Sep 2009 04:30:58 -0700 (PDT) In-Reply-To: <831vlvv2u8.fsf@gnu.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 25 Sep 2009 07:47:13 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31497 Archived-At: On Fri, Sep 25, 2009 at 10:35, Eli Zaretskii wrote: > Does this code cause an immediate redisplay? =C2=A0I think it doesn't, > which means shrink_mini_window does not actually shrink the window, it > just prepares the glyph matrices for that. =C2=A0The next redisplay will > actually change how things are shown on the screen. Hmm. The "else" part of shrink_mini_window (which works, in this case, if you force it to go that route) definitely shrinks the window: Lisp_Object window; XSETWINDOW (window, w); enlarge_window (window, 1 - XFASTINT (w->total_lines), 0); As for the "if" part, I think you're right. Anyway, the last patch by Martin worked as expected, at least for this bug. Is there any downside to it? Juanma