From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/lisp image.el Date: Sun, 30 Aug 2009 01:14:27 +0200 Message-ID: References: <87ljl2z3ex.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1251587741 1474 80.91.229.12 (29 Aug 2009 23:15:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2009 23:15:41 +0000 (UTC) Cc: Emacs developers To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 30 01:15:34 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MhX8O-0003NR-Ef for ged-emacs-devel@m.gmane.org; Sun, 30 Aug 2009 01:15:00 +0200 Original-Received: from localhost ([127.0.0.1]:58409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhX8N-0005Ch-J3 for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 19:14:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhX8J-0005CS-AU for emacs-devel@gnu.org; Sat, 29 Aug 2009 19:14:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhX8D-00058t-4n for emacs-devel@gnu.org; Sat, 29 Aug 2009 19:14:53 -0400 Original-Received: from [199.232.76.173] (port=38728 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhX8C-00058W-Uf for emacs-devel@gnu.org; Sat, 29 Aug 2009 19:14:48 -0400 Original-Received: from mail-fx0-f226.google.com ([209.85.220.226]:62211) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhX8C-0006DQ-H4 for emacs-devel@gnu.org; Sat, 29 Aug 2009 19:14:48 -0400 Original-Received: by fxm26 with SMTP id 26so2703511fxm.42 for ; Sat, 29 Aug 2009 16:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=rU/IBt5NZwiQ92aq7MIYIFu8vuRcrJH2GOjySltWg04=; b=QajtrYWCA2o6Eo3xWIpp3LTHhweOD8nDSkun1Dq5gcM7BOvnSRJS1vheRVUFIMpsUl AX9UNa3xgFcJBuxqljyozPO0q2/iC8uHWhn2YS3LX1PE9nope+jcgEEZITtWU/a6ACyv ydNAcyAx0VGiNhyXvykSKTHRzJj/QWO0tPm1M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Ry+oTkSQ7F/hCZhNxKcuN6M+VUb6nrWrVkO+EeHHIOqhqbMhWNopCqZr+hXfHnWwVp qahHmyV2TOMK2zTkjN7pKdbeJ3nULnetUl1ktcr493lyq0X8Zm6qyxNg6hDwI91TQrSo GCirtNrAxEjpZOk2kF5wEXbYjywL/87w/vhZs= Original-Received: by 10.239.170.34 with SMTP id q34mr252674hbe.3.1251587687065; Sat, 29 Aug 2009 16:14:47 -0700 (PDT) In-Reply-To: <87ljl2z3ex.fsf@mail.jurta.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114859 Archived-At: On Sun, Aug 30, 2009 at 00:46, Juri Linkov wrote: > I left `image-jpeg-p' in image.el for the case it's used by some > external packages or .emacs files since it contains a non-trivial > algorithm for detecting JFIF/Exif JPEGs. =C2=A0Even though its name is > not too specific, its docstring explains what it does. IMO, it is inconsistent with what image.el (or indeed Emacs) offers; we don't have functions to detect the different image formats supported by TIFF, for example. `image-jpeg-p' was never a published interface, just a helper function. As a very crude test, googling for it brings a few hits (plus "image/jpeg" false hits), most of which seem to be from our code or bug reports. It's unlikely the function has received wide usage (yes, private libraries and most .emacs files do not appear in Google; I said "crude"). If removing it is too severe, at least obsoleting it seems to be in order. It is unused in the sources, too specific, inconsistently documented, and internal. Juanma