From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/lisp image.el Date: Sat, 29 Aug 2009 02:21:24 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1251505327 15889 80.91.229.12 (29 Aug 2009 00:22:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2009 00:22:07 +0000 (UTC) Cc: Emacs developers To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 29 02:21:59 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MhBhd-0000Ki-AW for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 02:21:57 +0200 Original-Received: from localhost ([127.0.0.1]:47909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhBhc-0000pe-Mp for ged-emacs-devel@m.gmane.org; Fri, 28 Aug 2009 20:21:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhBhW-0000lX-6p for emacs-devel@gnu.org; Fri, 28 Aug 2009 20:21:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhBhR-0000iO-I0 for emacs-devel@gnu.org; Fri, 28 Aug 2009 20:21:49 -0400 Original-Received: from [199.232.76.173] (port=37146 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhBhR-0000iL-Ak for emacs-devel@gnu.org; Fri, 28 Aug 2009 20:21:45 -0400 Original-Received: from mail-fx0-f226.google.com ([209.85.220.226]:62200) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhBhQ-0001mM-VF for emacs-devel@gnu.org; Fri, 28 Aug 2009 20:21:45 -0400 Original-Received: by fxm26 with SMTP id 26so2263739fxm.42 for ; Fri, 28 Aug 2009 17:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=iSwS9S/3w/kLgISg8Op0BNsKZv9rmomtU9NFzqqD4LE=; b=JnbxHUJhsDIOgPHqbQHdlqWl2qpn87QpXJFhlJyn1oL0omUfCAc21BPM0ZME/WzypL kEXDlpMmT31CsgWY3Imu7mF9Umte0BzhefewJu0vtZO8yUsgjkqZkbxMM9uvp1gm03xR 8u7jn/ZtGeKJnPaU3lF6UHDhq0jVskQoq2qpg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=UHoFD0GeWLKi243hGdBQiOMPkM2AmNpLdc62B7mgiX52Pq5s8mi9jaPc5z22CY4NAE oSt2XHOoKcf+odv3Upc0EkTKYk5t9WXQ4tBL/4C2MB7czYEjyY2nMXtYJSsT6LEe3MNJ MXgiGcbGZEw+fJAZbyrvFoDnC+q/EXhPPrAEc= Original-Received: by 10.239.134.221 with SMTP id a29mr178826hba.20.1251505304088; Fri, 28 Aug 2009 17:21:44 -0700 (PDT) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114801 Archived-At: On Sat, Aug 29, 2009 at 01:49, Juri Linkov wrote: > Log message: > =C2=A0 =C2=A0 =C2=A0 =C2=A0(image-type-header-regexps): Use only JPEG mag= ic number > =C2=A0 =C2=A0 =C2=A0 =C2=A0to determine JPEG images, and don't use `image= -jpeg-p' because > =C2=A0 =C2=A0 =C2=A0 =C2=A0Emacs can display non-JFIF non-Exif JPEG image= s. Then we should perhaps obsolete `image-jpeg-p' (which is not used anymore in the sources). Currently it does what its docstring says, but there's some of a mismatch with the name (which seems to imply more generality); also it is not clear what purpose does serve a function to detect just JFIF/Exif JPEGs. And generalizing it would turn it into a trivial two-liner. Juanma