Re: [Emacs-diffs] emacs/src fontset.c

Re: [Emacs-diffs] emacs/src fontset.c

[Juanma Barranquero]

On Wed, Mar 11, 2009 at 08:51, Kenichi Handa <handa@m17n.org> wrote:

> +         font_object = font_open_by_spec (f, font_spec);

oo-spd/i386/temacs1.a(fontset.o): In function `Fset_fontset_font':
C:\emacs\src/fontset.c:1603: undefined reference to `font_open_by_spec'

    Juanma

Re: [Emacs-diffs] emacs/src fontset.c

[Miles Bader]

Juanma Barranquero <lekktu@gmail.com> writes:

> On Wed, Mar 11, 2009 at 08:51, Kenichi Handa <handa@m17n.org> wrote:
>
>> +         font_object = font_open_by_spec (f, font_spec);
>
> oo-spd/i386/temacs1.a(fontset.o): In function `Fset_fontset_font':
> C:\emacs\src/fontset.c:1603: undefined reference to `font_open_by_spec'

Yup, me too, on debian (with the latest libraries available in unstable installed).

-Miles

-- 
"Nah, there's no bigger atheist than me.  Well, I take that back.
I'm a cancer screening away from going agnostic and a biopsy away
from full-fledged Christian."  [Adam Carolla]

Re: [Emacs-diffs] emacs/src fontset.c

[Kenichi Handa]

In article <f7ccd24b0903110359o17d20ec1p1a7e6b60474c1c98@mail.gmail.com>, Juanma Barranquero <lekktu@gmail.com> writes:

> On Wed, Mar 11, 2009 at 08:51, Kenichi Handa <handa@m17n.org> wrote:
> > +         font_object = font_open_by_spec (f, font_spec);

> oo-spd/i386/temacs1.a(fontset.o): In function `Fset_fontset_font':
> C:\emacs\src/fontset.c:1603: undefined reference to `font_open_by_spec'

Please try again.  I committed all changes.

---
Kenichi Handa
handa@m17n.org

Re: [Emacs-diffs] emacs/src fontset.c

[Chong Yidong]

Kenichi Handa <handa@m17n.org> writes:

> Please try again.  I committed all changes.

What is the purpose of these latest changes?

Re: [Emacs-diffs] emacs/src fontset.c

[Kenichi Handa]

In article <87eix49ppl.fsf@cyd.mit.edu>, Chong Yidong <cyd@stupidchicken.com> writes:

> Kenichi Handa <handa@m17n.org> writes:
> > Please try again.  I committed all changes.

> What is the purpose of these latest changes?

To fix this problem reported a while ago:

In article <760897560812160136v32810859x92081fde365dee1e@mail.gmail.com>, "Qichen Huang" <unicad.el@gmail.com> writes:

> run emacs without any extra settings: runemacs.exe -Q

> (set-fontset-font
>  "fontset-startup" 'ascii  ;; or 'latin
>  "-*-Courier New-*-*-*-*-17-*-*-*-*-*-iso8859-1")

> or

> (set-fontset-font (frame-parameter nil 'font)
> 		  'ascii  ;; or 'latin
> 		  (font-spec :family "Courier New" :size 17))

> Neither work.

In the new code, when a font for ASCII is changed in a
fontset, the default font is changed to that new font in all
frames that are using the same fontset.

By the way, after the following change, (frame-parameter nil
'font) doesn't return a fontset of the current frame.

2009-01-14  Jason Rumney  <jasonr@gnu.org>

	* frame.c (x_set_font): Always store a font to the font parameter,
	never a fontset.  (Bug#1562)

Now the right way to get a fontset is:
   (face-attribute 'default :fontset)

---
Kenichi Handa
handa@m17n.org

Re: [Emacs-diffs] emacs/src fontset.c

[Jason Rumney]

Kenichi Handa wrote:
> By the way, after the following change, (frame-parameter nil
> 'font) doesn't return a fontset of the current frame.
>
> 2009-01-14  Jason Rumney  <jasonr@gnu.org>
>
> 	* frame.c (x_set_font): Always store a font to the font parameter,
> 	never a fontset.  (Bug#1562)
>
> Now the right way to get a fontset is:
>    (face-attribute 'default :fontset)
>   

Perhaps (frame-parameter nil 'fontset) could be made to work also.  I 
made that change because it seemed the most obvious way to fix Bug#1562, 
and since we have both FRAME_FONTSET (f) and FRAME_FONT (f), which in 
the previous code both returned fontsets under some circumstances. It 
seemed cleaner to have FRAME_FONTSET always return a fontset, and 
FRAME_FONT always return a font.

Re: [Emacs-diffs] emacs/src fontset.c

[Kenichi Handa]

In article <49B907DF.8080004@gnu.org>, Jason Rumney <jasonr@gnu.org> writes:

> Kenichi Handa wrote:
> > By the way, after the following change, (frame-parameter nil
> > 'font) doesn't return a fontset of the current frame.
> >
> > 2009-01-14  Jason Rumney  <jasonr@gnu.org>
> >
> > 	* frame.c (x_set_font): Always store a font to the font parameter,
> > 	never a fontset.  (Bug#1562)
> >
> > Now the right way to get a fontset is:
> >    (face-attribute 'default :fontset)
> >   

> Perhaps (frame-parameter nil 'fontset) could be made to work also.  

But then, don't we have to think about the semantics of this?
  (modify-frame-parameters nil '((fontset . ...)))

> I made that change because it seemed the most obvious way
> to fix Bug#1562,

I see.

> and since we have both FRAME_FONTSET (f)
> and FRAME_FONT (f), which in the previous code both
> returned fontsets under some circumstances. It seemed
> cleaner to have FRAME_FONTSET always return a fontset, and
> FRAME_FONT always return a font.

??? If there's a case that FRAME_FONT (f) returns a fontset,
it's a bug.  In what circumstances, does it happen?

---
Kenichi Handa
handa@m17n.org