From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#2553: *vc-diff* buffers are read-only, but M-k works Date: Wed, 4 Mar 2009 16:54:46 +0100 Message-ID: References: <87k575jnwl.fsf@cyd.mit.edu> Reply-To: Juanma Barranquero , 2553@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1236182714 18485 80.91.229.12 (4 Mar 2009 16:05:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Mar 2009 16:05:14 +0000 (UTC) Cc: David Reitter , 2553@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 04 17:06:29 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LetbY-0003At-8D for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Mar 2009 17:05:57 +0100 Original-Received: from localhost ([127.0.0.1]:38029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LetaC-0004k4-V6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Mar 2009 11:04:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LetZQ-0004Qm-Q9 for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LetZP-0004Ph-4Q for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:44 -0500 Original-Received: from [199.232.76.173] (port=37567 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LetZP-0004Pd-1E for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:43 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35542) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LetZO-0002FP-9y for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:42 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n24G3doY000648; Wed, 4 Mar 2009 08:03:39 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n24G03RD031976; Wed, 4 Mar 2009 08:00:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juanma Barranquero Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 04 Mar 2009 16:00:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2553 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2553-submit@emacsbugs.donarmstrong.com id=B2553.123618209130529 (code B ref 2553); Wed, 04 Mar 2009 16:00:03 +0000 Original-Received: (at 2553) by emacsbugs.donarmstrong.com; 4 Mar 2009 15:54:51 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.25]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n24FslmI030523 for <2553@emacsbugs.donarmstrong.com>; Wed, 4 Mar 2009 07:54:48 -0800 Original-Received: by ey-out-2122.google.com with SMTP id 25so624911eya.13 for <2553@emacsbugs.donarmstrong.com>; Wed, 04 Mar 2009 07:54:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Fl6D34FN1mniRam0+fpZ2oagbHg32T2oNsAnU5Tck+w=; b=g+N/ciRtJz+mTBdt5cdp3KdDiPMApoXIvEUwnvgROWgLPokakw+g4ndmzs0H/XpANk dcbASHXEKOFSE89x9V9FpUbgwoJvX8O+5bx4K57KVoQvYkUHJORSIupSOUd0XxDk3AHB 0nt/pH5RQ1mYgUkx7oXYZ2xlxUiB/k59tuwM4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=f+Jqdn6VdAVfQKjD764DjxMa62FrZ7ELwGbleQm8lG1tNiAnXEjpjQMo8glnbVGQ8c jIMeoNSp+HPeTuGa6tsVvhWHghmy7qlwCEyinICMrwmk0gIYNZTV2HDBi9nZo1B83Nvd LcOL8tzQrKKLG1gpprw08+5PBVYVSRrcyVUec= Original-Received: by 10.210.112.4 with SMTP id k4mr5098213ebc.5.1236182086793; Wed, 04 Mar 2009 07:54:46 -0800 (PST) In-Reply-To: <87k575jnwl.fsf@cyd.mit.edu> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 04 Mar 2009 11:03:44 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25974 Archived-At: On Wed, Mar 4, 2009 at 16:41, Chong Yidong wrote: >=C2=A0However, it's counter-intuitive that undo does not work. > Probably the easiest fix is to define a diff-undo command that lifts the > read-only restriction temporarily. =C2=A0Any thoughts? Most operations on diff-mode buffers do not change the buffer or are easily reversible (diff-reverse-direction, diff-unified->context, etc.). Making the buffer read-write is a C-x C-q away, if the user needs to use undo or normal editing commands. What is a bit of a pain is that the user cannot easily setup vc-diff to default to a read-write buffer, because there's no vc-diff-hook and `(setq buffer-read-only t)' is done after calling diff-mode, so diff-mode-hook isn't useful either. The only way right now (other than modifying the source) is to advise vc-diff. My 0.02=E2=82=AC Juanma