From: Juanma Barranquero <lekktu@gmail.com>
To: Emacs Bug Tracker <submit@emacsbugs.donarmstrong.com>
Subject: bug#2357: imenu-add-menubar-index fails in Objective-C mode
Date: Tue, 17 Feb 2009 13:22:21 +0100 [thread overview]
Message-ID: <f7ccd24b0902170422s486b8726m753c738c4cb59967@mail.gmail.com> (raw)
Package: emacs,cc-mode
[This part is a bugfix]
emacs -Q --visit nsfns.m --f imenu-add-menubar-index
=> Error in menu-bar-update-hook: (invalid-function imenu-progress-message)
The reason is that progmodes/cc-menus.el does
(cc-bytecomp-defun imenu-progress-message)
to avoid loading imenu.el, and then uses `imenu-progress-message' in
Objective-C specific code (cc-imenu-objc-function). But it is a macro,
so it fails.
I think the best way to fix it is just removing the cc-bytecomp-defun
and all calls to imenu-progress-message from cc-menus.el. That macro
has been defined as a no-op since 2004-10-27 and I don't think it is
worth jumping around hoops just to make cc-menus.el successfully
define something that goes unused.
[This part is not a bugfix, so not needed now]
Additionally, there are useless calls to `imenu-progress-message' in
imenu.el, erc/erc-imenu.el and net/smtp-mode.el. For the latter two,
removing the macro calls would also remove the need to require imenu.
Juanma
2009-02-17 Juanma Barranquero <lekktu@gmail.com>
* progmodes/cc-menus.el (imenu-progress-message):
Remove (bogus and useless) cc-bytecomp-defun.
(cc-imenu-objc-function): Don't call `imenu-progress-message'.
Don't let-bind unused variable `stupid'.
Index: lisp/progmodes/cc-menus.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/cc-menus.el,v
retrieving revision 1.42
diff -u -2 -r1.42 cc-menus.el
--- lisp/progmodes/cc-menus.el 17 Feb 2009 10:59:14 -0000 1.42
+++ lisp/progmodes/cc-menus.el 17 Feb 2009 11:51:30 -0000
@@ -48,5 +48,4 @@
(cc-bytecomp-defvar imenu-generic-expression)
(cc-bytecomp-defvar imenu-create-index-function)
-(cc-bytecomp-defun imenu-progress-message)
\f
@@ -317,5 +316,4 @@
(classcount 0)
toplist
- stupid
str
str2
@@ -331,8 +329,6 @@
'buffer-substring)))
(goto-char (point-max))
- (imenu-progress-message stupid 0)
;;
(while (re-search-backward cc-imenu-objc-generic-expression nil t)
- (imenu-progress-message stupid)
(setq langnum (if (match-beginning OBJC)
OBJC
@@ -386,5 +382,4 @@
methodlist nil))))
;;
- (imenu-progress-message stupid 100)
(if (eq (car toplist) nil)
(setq toplist (cdr toplist)))
next prev reply other threads:[~2009-02-17 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b0902180124n7f94606ax4248bd23046d984c@mail.gmail.com>
2008-12-19 6:30 ` bug#1638: got "invalid-function imenu-progress-message" in objc-mode Meteor Liu
2009-02-18 9:30 ` bug#1638: marked as done (got "invalid-function imenu-progress-message" in objc-mode) Emacs bug Tracking System
2009-02-17 12:22 ` Juanma Barranquero [this message]
2009-02-18 2:57 ` bug#2357: imenu-add-menubar-index fails in Objective-C mode Stefan Monnier
2009-02-18 9:30 ` bug#2357: marked as done (imenu-add-menubar-index fails in Objective-C mode) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0902170422s486b8726m753c738c4cb59967@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=2357@emacsbugs.donarmstrong.com \
--cc=submit@emacsbugs.donarmstrong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.