From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffs Digest, Vol 74, Issue 135 Date: Fri, 30 Jan 2009 14:14:26 +0100 Message-ID: References: <87ocxpotng.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233321299 6483 80.91.229.12 (30 Jan 2009 13:14:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Jan 2009 13:14:59 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 30 14:16:11 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LStDv-00064e-Oa for ged-emacs-devel@m.gmane.org; Fri, 30 Jan 2009 14:15:56 +0100 Original-Received: from localhost ([127.0.0.1]:42891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LStCc-0008DE-GZ for ged-emacs-devel@m.gmane.org; Fri, 30 Jan 2009 08:14:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LStCY-0008D8-Sf for emacs-devel@gnu.org; Fri, 30 Jan 2009 08:14:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LStCX-0008Cu-Eg for emacs-devel@gnu.org; Fri, 30 Jan 2009 08:14:30 -0500 Original-Received: from [199.232.76.173] (port=33941 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LStCX-0008Cr-Ci for emacs-devel@gnu.org; Fri, 30 Jan 2009 08:14:29 -0500 Original-Received: from mail-ew0-f20.google.com ([209.85.219.20]:59456) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LStCW-0006Sn-4n; Fri, 30 Jan 2009 08:14:28 -0500 Original-Received: by ewy13 with SMTP id 13so850469ewy.18 for ; Fri, 30 Jan 2009 05:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=5CPoOdC7fRp3Xb8fWyQbFVfNTZTenZC2zHiCHOHEj4w=; b=bJuyrCQ43iX4WSLRnFJCH7LDdQwgX00KdzaUbf1ThObjeRpopLRPNk2L5CqyIZVaiq 457/+8CzA5zUnerQoV4CQUlqb0015fqiKUles1sKdkxqYMZQx6SPJAQdbHFs++jHlx+e Keet9/wJyRgrEiIgfNAoZ4ScroraxTJMbX86s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=csIlwtyqJmsaKtRUv9G2ujiLv1b1hOAU4dd2I58c4fkMUOfiEf4nqmOWHwagckx/uv blELeXHSNkgVmCIwXglSTJtRnchFLg/hdTMFA44baSVFgPeSFKy2E67KHsWkNTQ4WIxg U4J9cT0CwIii97qk3RcKy5EiuHYXj9pKdWR+8= Original-Received: by 10.210.119.16 with SMTP id r16mr1352878ebc.91.1233321266623; Fri, 30 Jan 2009 05:14:26 -0800 (PST) In-Reply-To: <87ocxpotng.fsf@cyd.mit.edu> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108404 Archived-At: On Fri, Jan 30, 2009 at 13:38, Chong Yidong wrote: > Juanma has a patch putting pending_signals in #ifdef SYNC_INPUT, and > I've just asked him to commit it. That said, I think that's ugly as hell (I've committed it so Emacs compiles again). pending_signals could be defined in lisp.h outside the "#ifdef SYNC_INPUT", which would save a lot of #ifdefs, with the only side effect that the variable would be assigned in several situations, but not used (on non-SYNC_INPUT builds). That's not pretty either, but I think that's what's done with interrupt_input_pending. Or we could use a macro to set pending_signals, which would do nothing in the relevant case. Juanma