From: Juanma Barranquero <lekktu@gmail.com>
To: Emacs Bug Tracker <submit@emacsbugs.donarmstrong.com>
Subject: bug#2062: PATH can contain non-expanded variables
Date: Mon, 26 Jan 2009 14:00:15 +0100 [thread overview]
Message-ID: <f7ccd24b0901260500h18a7ac63uf5c88cbb515ddeb0@mail.gmail.com> (raw)
Package: emacs,w32
Version: 23.0.60
It is possible for PATH (or other path-like variables, like EMACSPATH
and EMACSLOADPATH) to contain unexpanded variables:
ELISP> exec-path
("c:/emacs/bin" "%MYTEST%" "C:/WINDOWS/system32" "C:/WINDOWS"
"C:/WINDOWS/system32/Wbem" "c:/emacs/trunk/bin")
for example, if the user has set
"HKLM\Microsoft\Windows\CurrentVersion\App Paths\emacs.exe\Path" as a
REG_EXPAND_SZ.
These variables should be expanded, but currently
emacs.c:decode_env_path does not. The following patch fixes it.
Comments?
Juanma
Index: emacs.c
===================================================================
RCS file: /sources/emacs/emacs/src/emacs.c,v
retrieving revision 1.461
diff -u -2 -r1.461 emacs.c
--- emacs.c 23 Jan 2009 14:53:11 -0000 1.461
+++ emacs.c 26 Jan 2009 12:48:49 -0000
@@ -2467,6 +2467,12 @@
if (path)
{
+#ifdef WINDOWSNT
+ DWORD required = ExpandEnvironmentStrings (path, NULL, 0);
+ p = (char *) alloca (required);
+ ExpandEnvironmentStrings (path, p, required);
+#else
p = alloca (strlen (path) + 1);
strcpy (p, path);
+#endif
path = p;
next reply other threads:[~2009-01-26 13:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b0901280707u39a4364bk76339f2e5956fa5@mail.gmail.com>
2009-01-26 13:00 ` Juanma Barranquero [this message]
2009-01-26 22:01 ` bug#2062: PATH can contain non-expanded variables Lennart Borgman
2009-01-27 1:56 ` Jason Rumney
2009-01-27 8:34 ` Juanma Barranquero
2009-01-27 9:24 ` Jason Rumney
2009-01-27 10:25 ` Juanma Barranquero
2009-01-27 13:29 ` Jason Rumney
2009-01-27 14:42 ` Juanma Barranquero
2009-01-27 19:02 ` Stefan Monnier
2009-01-27 20:00 ` Juanma Barranquero
2009-01-28 8:39 ` Jason Rumney
2009-01-28 8:45 ` Juanma Barranquero
2009-01-27 19:30 ` Eli Zaretskii
2009-01-27 19:55 ` Juanma Barranquero
2009-01-28 4:12 ` Eli Zaretskii
2009-01-28 8:36 ` Juanma Barranquero
2009-01-28 14:24 ` Stefan Monnier
2009-01-28 15:15 ` bug#2062: marked as done (PATH can contain non-expanded variables) Emacs bug Tracking System
2009-01-28 19:09 ` bug#2062: PATH can contain non-expanded variables Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0901260500h18a7ac63uf5c88cbb515ddeb0@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=2062@emacsbugs.donarmstrong.com \
--cc=submit@emacsbugs.donarmstrong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.