From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#1952: 23.0.60[W32-Mingw]; opening etc/HELLO is slower than before Date: Tue, 20 Jan 2009 16:49:37 +0100 Message-ID: References: <42b562540901181840v1cfc73bbxec292b40aa4a60aa@mail.gmail.com> <49748AAE.6070509@gnu.org> <4975C8F0.7070302@gnu.org> Reply-To: Juanma Barranquero , 1952@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1232467532 26465 80.91.229.12 (20 Jan 2009 16:05:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Jan 2009 16:05:32 +0000 (UTC) Cc: Kevin Yu , 1952@emacsbugs.donarmstrong.com To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 20 17:06:44 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LPJ6s-0002xa-Bv for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Jan 2009 17:05:51 +0100 Original-Received: from localhost ([127.0.0.1]:34443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPJ5b-0002H0-8K for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Jan 2009 11:04:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPJ4e-0001pK-UK for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 11:03:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPJ4d-0001o6-AM for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 11:03:32 -0500 Original-Received: from [199.232.76.173] (port=46503 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPJ4c-0001ny-Tl for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 11:03:30 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:58056) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LPJ4c-00033Y-7C for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 11:03:30 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0KG3RFw014025; Tue, 20 Jan 2009 08:03:28 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0KFt3rS011769; Tue, 20 Jan 2009 07:55:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juanma Barranquero Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 20 Jan 2009 15:55:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1952 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1952-submit@emacsbugs.donarmstrong.com id=B1952.123246658710466 (code B ref 1952); Tue, 20 Jan 2009 15:55:03 +0000 Original-Received: (at 1952) by emacsbugs.donarmstrong.com; 20 Jan 2009 15:49:47 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0KFnhxh010460 for <1952@emacsbugs.donarmstrong.com>; Tue, 20 Jan 2009 07:49:44 -0800 Original-Received: by ewy3 with SMTP id 3so1914210ewy.1 for <1952@emacsbugs.donarmstrong.com>; Tue, 20 Jan 2009 07:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=83rP8BrA1TUH8y1rO4l9weCUIVUT6MDJCOdmsb9duo0=; b=UpDq9iOKblvw5bLfl1iWJb0eO7F/nMEeg+s1U0628oxjAenmlE3GlUpYpOKfxLW5YX d/WIb7cRiloAbWDFPCcWpm/ox37bEOk8B5BLYQbgLoKGXDW6FFrkYTRLl+o1NUa/bQ5V POp68zXvKJVbn1vDvcT7IFU4z26IZvdxdDkgg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=TZLltIbMiPg0j90pjmiFH4i0BAYwjEQUzaJ5evVl6rr34+/8gAwYte6LKbv51dY3oq 6aoz7mPXnC4Aqmh8SF9A8qS+lfeCq6cBDOyOkokNpH0IDduEcuxWV5XAJ+rSCnYKoLx8 r1Wb8JBWiXVjY9gGjuZ7kcDEIsjeY5ZEwhAzE= Original-Received: by 10.210.29.11 with SMTP id c11mr1593392ebc.197.1232466577770; Tue, 20 Jan 2009 07:49:37 -0800 (PST) In-Reply-To: <4975C8F0.7070302@gnu.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 20 Jan 2009 11:03:32 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24326 Archived-At: On Tue, Jan 20, 2009 at 13:52, Jason Rumney wrote: > This function was supposed to abort the font > enumeration as soon as a match was found. But previously the logic was wrong > so it was aborting if the first font did not match the given font-spec. So > in the majority of cases, it would only enumerate one font and return nil, > only if the first font matched would it go through every font in the system > and return all the fonts that matched. After the fix, it will go through all > the fonts for characters that do not have a matching font installed, and > will go through enough fonts to find a match for others. The change that causes the slowdown in my system is not the one to add_one_font_entity_to_list, but this one to add_font_entity_to_list: @@ -1449,6 +1449,5 @@ && !EQ (spec_charset, Qunicode_bmp) && !EQ (spec_charset, Qunicode_sip) - && match_data->pattern.lfCharSet == DEFAULT_CHARSET - && logical_font->elfLogFont.lfCharSet != DEFAULT_CHARSET) + && match_data->pattern.lfCharSet == DEFAULT_CHARSET) return 0; Reverting this bit eliminates the problem. Juanma