From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.bugs Subject: bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c Date: Wed, 3 Dec 2008 23:15:42 +0100 Message-ID: References: <200812030635.mB36Z9mk024296@mothra.ics.uci.edu> <1228291406.49363d4ebc7d8@webmail.freedom2surf.net> <200812031524.mB3FOBqt025290@mothra.ics.uci.edu> <200812031915.mB3JF4ts026816@mothra.ics.uci.edu> <200812032203.mB3M3jGD028987@mothra.ics.uci.edu> Reply-To: Juanma Barranquero , 1483@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1228343467 21155 80.91.229.12 (3 Dec 2008 22:31:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2008 22:31:07 +0000 (UTC) Cc: 1483@emacsbugs.donarmstrong.com, jasonr@f2s.com To: "Dan Nicolaescu" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 03 23:32:09 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L80Fr-0004cm-UA for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 23:31:36 +0100 Original-Received: from localhost ([127.0.0.1]:60306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L80Eh-00087A-AO for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 17:30:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L80Ed-000875-Vq for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:30:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L80Ec-00086r-2L for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:30:19 -0500 Original-Received: from [199.232.76.173] (port=35279 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L80Eb-00086n-Rl for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:30:17 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54431) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L80Eb-0007ej-Cq for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 17:30:17 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3MUD9V003025; Wed, 3 Dec 2008 14:30:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB3MP4rN001251; Wed, 3 Dec 2008 14:25:04 -0800 X-Loop: don@donarmstrong.com Resent-From: "Juanma Barranquero" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 03 Dec 2008 22:25:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1483 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1483-submit@emacsbugs.donarmstrong.com id=B1483.122834255132254 (code B ref 1483); Wed, 03 Dec 2008 22:25:04 +0000 Original-Received: (at 1483) by emacsbugs.donarmstrong.com; 3 Dec 2008 22:15:51 +0000 Original-Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.188]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3MFmv6032247 for <1483@emacsbugs.donarmstrong.com>; Wed, 3 Dec 2008 14:15:49 -0800 Original-Received: by rn-out-0910.google.com with SMTP id j66so3420930rne.20 for <1483@emacsbugs.donarmstrong.com>; Wed, 03 Dec 2008 14:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=ThchQ66uKNlBp+Ckb1K8svlfWr49g5368RTHx1oreU0=; b=MWDOZGCSzCHTP/Ax7MyaXVjngA5L43mYY+n8AMycMogvM6RtepI1SrqRh4HVXGoN4K l7p7w9qYmUokl699LAB2aYQQQBB7YMkLuaN5nVnGZy4g4dqf78zT1Ckoas+DnLLB6BHz t3rNR2HhMr4pqLo7meiKLMhwgkaeXPEu3HUtc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=YJ6pWuZxG7QGV4KOD6cqCdzqD9zeIQmhQxtih8PuSZYiwzqDE1PJsSN++z4M7G0I1F HlXrgxVmO2c5JN9YJFjdo5SfSNRucDSxkposoTKh1MbLpMo7abXqoXTSiHxqfD0J+6rW /9CgkFUIv1BY43sPbbsVkRxQhKskIzHuVdiUE= Original-Received: by 10.101.69.10 with SMTP id w10mr8083675ank.98.1228342542922; Wed, 03 Dec 2008 14:15:42 -0800 (PST) Original-Received: by 10.100.13.13 with HTTP; Wed, 3 Dec 2008 14:15:42 -0800 (PST) In-Reply-To: <200812032203.mB3M3jGD028987@mothra.ics.uci.edu> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 03 Dec 2008 17:30:19 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22928 Archived-At: On Wed, Dec 3, 2008 at 23:03, Dan Nicolaescu wrote: > Because it's simpler. Simpler does not always imply clearer. > Good luck convincing anyone about that. I don't have to convince anyone, because I'm not proposing changing anything. You're the one who wants to do it, and until this moment three people who have modified that code more or less extensively have expressed their opposition to the idea. > There are 378 undocumented > macros in admin/CPP-DEFINES, and probably 1000-2000 in use in src/*, > increasing that number does not seem such a hot idea. That's like saying "there are thousand of undocumented local variables in the sources, let's reuse variables instead of creating new ones". If they are undocumented, the way to fix it is documenting them, not conflating them in as few as possible. > This is not a valid proof. Maybe people didn't want to complain, or > didn't figure out the difference, etc. Yeah, or maybe not. But we're talking of people who's hacked that source and apparently didn't have any trouble. > Still not too good, and a deviation from the normal style of not having > includes in the middle of the file. process.c has an include at line 388, and I've just looked for a few seconds. But still, if you want to change it and the result is clearer, by all means go ahead. Juanma