bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c

["Juanma Barranquero" <lekktu@gmail.com>]

On Wed, Dec 3, 2008 at 23:03, Dan Nicolaescu <dann@ics.uci.edu> wrote:

> Because it's simpler.

Simpler does not always imply clearer.

> Good luck convincing anyone about that.

I don't have to convince anyone, because I'm not proposing changing
anything. You're the one who wants to do it, and until this moment
three people who have modified that code more or less extensively have
expressed their opposition to the idea.

> There are 378 undocumented
> macros in admin/CPP-DEFINES, and probably 1000-2000 in use in src/*,
> increasing that number does not seem such a hot idea.

That's like saying "there are thousand of undocumented local variables
in the sources, let's reuse variables instead of creating new ones".
If they are undocumented, the way to fix it is documenting them, not
conflating them in as few as possible.

> This is not a valid proof.  Maybe people didn't want to complain, or
> didn't figure out the difference, etc.

Yeah, or maybe not. But we're talking of people who's hacked that
source and apparently didn't have any trouble.

> Still not too good, and a deviation from the normal style of not having
> includes in the middle of the file.

process.c has an include at line 388, and I've just looked for a few seconds.

But still, if you want to change it and the result is clearer, by all
means go ahead.

    Juanma