From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Dan Nicolaescu" <dann@ics.uci.edu>
Cc: 1483@emacsbugs.donarmstrong.com, jasonr@f2s.com
Subject: bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c
Date: Wed, 3 Dec 2008 23:15:42 +0100 [thread overview]
Message-ID: <f7ccd24b0812031415s70d33387lc754c5c6f6a2a8d6@mail.gmail.com> (raw)
In-Reply-To: <200812032203.mB3M3jGD028987@mothra.ics.uci.edu>
On Wed, Dec 3, 2008 at 23:03, Dan Nicolaescu <dann@ics.uci.edu> wrote:
> Because it's simpler.
Simpler does not always imply clearer.
> Good luck convincing anyone about that.
I don't have to convince anyone, because I'm not proposing changing
anything. You're the one who wants to do it, and until this moment
three people who have modified that code more or less extensively have
expressed their opposition to the idea.
> There are 378 undocumented
> macros in admin/CPP-DEFINES, and probably 1000-2000 in use in src/*,
> increasing that number does not seem such a hot idea.
That's like saying "there are thousand of undocumented local variables
in the sources, let's reuse variables instead of creating new ones".
If they are undocumented, the way to fix it is documenting them, not
conflating them in as few as possible.
> This is not a valid proof. Maybe people didn't want to complain, or
> didn't figure out the difference, etc.
Yeah, or maybe not. But we're talking of people who's hacked that
source and apparently didn't have any trouble.
> Still not too good, and a deviation from the normal style of not having
> includes in the middle of the file.
process.c has an include at line 388, and I've just looked for a few seconds.
But still, if you want to change it and the result is clearer, by all
means go ahead.
Juanma
next prev parent reply other threads:[~2008-12-03 22:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 6:35 bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c Dan Nicolaescu
2008-12-03 8:03 ` jasonr
2008-12-03 15:24 ` Dan Nicolaescu
2008-12-03 15:33 ` Juanma Barranquero
2008-12-03 19:15 ` Dan Nicolaescu
2008-12-03 21:08 ` Juanma Barranquero
2008-12-03 22:03 ` Dan Nicolaescu
2008-12-03 22:15 ` Juanma Barranquero [this message]
2008-12-03 23:51 ` Juanma Barranquero
2008-12-04 4:13 ` Eli Zaretskii
2011-07-04 11:34 ` Juanma Barranquero
2008-12-03 18:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0812031415s70d33387lc754c5c6f6a2a8d6@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=1483@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
--cc=jasonr@f2s.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.