From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.bugs Subject: bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c Date: Wed, 3 Dec 2008 22:08:00 +0100 Message-ID: References: <200812030635.mB36Z9mk024296@mothra.ics.uci.edu> <1228291406.49363d4ebc7d8@webmail.freedom2surf.net> <200812031524.mB3FOBqt025290@mothra.ics.uci.edu> <200812031915.mB3JF4ts026816@mothra.ics.uci.edu> Reply-To: Juanma Barranquero , 1483@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1228339858 7838 80.91.229.12 (3 Dec 2008 21:30:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2008 21:30:58 +0000 (UTC) Cc: 1483@emacsbugs.donarmstrong.com, jasonr@f2s.com To: "Dan Nicolaescu" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 03 22:32:00 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7zJp-0006vP-PA for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 22:31:38 +0100 Original-Received: from localhost ([127.0.0.1]:54451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7zIf-0007Ha-8g for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 16:30:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7zIb-0007HH-H0 for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 16:30:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7zIa-0007Gh-1I for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 16:30:21 -0500 Original-Received: from [199.232.76.173] (port=60983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7zIZ-0007Gd-Mc for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 16:30:19 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34356) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L7zIZ-0001xS-3n for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 16:30:19 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3LUDag019815; Wed, 3 Dec 2008 13:30:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB3LF2Hs015528; Wed, 3 Dec 2008 13:15:02 -0800 X-Loop: don@donarmstrong.com Resent-From: "Juanma Barranquero" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 03 Dec 2008 21:15:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1483 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1483-submit@emacsbugs.donarmstrong.com id=B1483.122833848814278 (code B ref 1483); Wed, 03 Dec 2008 21:15:02 +0000 Original-Received: (at 1483) by emacsbugs.donarmstrong.com; 3 Dec 2008 21:08:08 +0000 Original-Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.190]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3L85Jp014272 for <1483@emacsbugs.donarmstrong.com>; Wed, 3 Dec 2008 13:08:06 -0800 Original-Received: by rn-out-0910.google.com with SMTP id j66so3385291rne.20 for <1483@emacsbugs.donarmstrong.com>; Wed, 03 Dec 2008 13:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=DFCvJsCMVJyLDt2X/f4sVxPdo85EnF960Gm6I/fQP+A=; b=L5Zp1xkqB9s0QaVA0yN8cuipSs4h2qQCtP40q7Z4zZ5lWKFXsADtqbKZWpTI42Dw65 xSPHVs7vSWAvyKYuS6CZORlQd1K7Y9+rnyYUj68qA/Ba829AuTubVNesN7hUWeiI4xd9 rgiXP6qUsrUpXsDOa3SE4IAR7NIK7RhOkjN7E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=e/MZd5G0GEaTf1E5Vp0JAbaO7JwCAZBZsyL0aCqEk/2k2d76foO/cnkSEJUE5GRllG ED5be5GS/o37KWZOYgvu79lPB96kCICGqmEAIPyaAMczUP7eLGh2RI7NXCJUVYIDTrNp vv1nV5c9FCeLH9CGJEVJaTDEGfg70/M/zz7Dw= Original-Received: by 10.100.111.11 with SMTP id j11mr8073292anc.15.1228338480993; Wed, 03 Dec 2008 13:08:00 -0800 (PST) Original-Received: by 10.100.13.13 with HTTP; Wed, 3 Dec 2008 13:08:00 -0800 (PST) In-Reply-To: <200812031915.mB3JF4ts026816@mothra.ics.uci.edu> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 03 Dec 2008 16:30:21 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22921 Archived-At: On Wed, Dec 3, 2008 at 20:15, Dan Nicolaescu wrote: > should only need a single #ifdef. Why? > The clear precedent is that WINDOWSNT already encompasses a bazillion > features, why would a bazillion + 1 won't make any difference? As Eli pointed out, we should be moving towards decreasing the bazillion things conflated into #ifdef WINDOWSNT, not increasing them. > It would > make a difference for the vast majority of people that write to the > emacs repository, most do not use windows and can just ignore the #ifdef > WINDOWSNT code. Apparently it's not that confusing. There has been no complain until now from the people who's hacked on emacsclient. > On a not so related note, why are there #includes on line 671 in > emacsclient.c instead of at the beginning of the file? Because they affect code inside a big #else which goes from there to the end of the file. They were already there before the TCP socket support, indeed from version 1.1 of the file (though it was line 49 back then...) Juanma