From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: size of emacs executable after unicode merge Date: Fri, 28 Nov 2008 17:11:31 +0100 Message-ID: References: <87iqqwk672.fsf@cyd.mit.edu> <873ahym8ji.fsf@cyd.mit.edu> <87r65flh5n.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1227888720 9245 80.91.229.12 (28 Nov 2008 16:12:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Nov 2008 16:12:00 +0000 (UTC) Cc: Emacs developers To: "Kenichi Handa" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 28 17:13:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L65xc-0006Ci-5P for ged-emacs-devel@m.gmane.org; Fri, 28 Nov 2008 17:12:52 +0100 Original-Received: from localhost ([127.0.0.1]:43785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L65wS-0001nr-3e for ged-emacs-devel@m.gmane.org; Fri, 28 Nov 2008 11:11:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L65wN-0001nm-Ng for emacs-devel@gnu.org; Fri, 28 Nov 2008 11:11:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L65wL-0001nW-8l for emacs-devel@gnu.org; Fri, 28 Nov 2008 11:11:34 -0500 Original-Received: from [199.232.76.173] (port=59702 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L65wL-0001nT-62 for emacs-devel@gnu.org; Fri, 28 Nov 2008 11:11:33 -0500 Original-Received: from yw-out-1718.google.com ([74.125.46.158]:19197) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L65wK-000346-SN for emacs-devel@gnu.org; Fri, 28 Nov 2008 11:11:33 -0500 Original-Received: by yw-out-1718.google.com with SMTP id 9so611706ywk.66 for ; Fri, 28 Nov 2008 08:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=NNpaA4mrEryILl1CXf9wIAkXlf19EIUfK+yjVVISRnU=; b=LA3qhiEmc1TUeq/7VjXE0wwSB6BTvFAERi7t6ISDFo4gS+xJ7odHBDwkJUuNb54gB+ RJSwdd/C9nh1wNtXarhPK8DIBKwIPgzBn0uM+6Iqv+QTnqCZ3lTTokwNGgFa+xIDq6ri qWHVzCSK31hk6lts6rHK53aum/xQpVBRor2fw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=lT+7PweYmOih0ZyIzCpovzFvCaDOOAeVAooL4n+uL4gazNFXkkpP1D65dS1EFoxVEj vFMok0fQpTlawICdkZoZgDl8n3pLSTwe21BpRwuUE7n1IdBVasgHwB1g4BqdkA27oZQu htqETlrEweJKGI+DT4hxlujFPfxRI7QnYg3uU= Original-Received: by 10.100.132.5 with SMTP id f5mr4210340and.85.1227888691846; Fri, 28 Nov 2008 08:11:31 -0800 (PST) Original-Received: by 10.100.13.13 with HTTP; Fri, 28 Nov 2008 08:11:31 -0800 (PST) In-Reply-To: Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106267 Archived-At: On Thu, Nov 27, 2008 at 12:20, Kenichi Handa wrote: > After taking over Chong's experiment, I could reduce the > size of Emacs executables about 7M bytes. About 4M bytes > were actually because of charset mapping tables, and it > could be reduced by setting up C structure temp_charset_work Your big patch of 2008-11-27 has caused a change when decoding some filenames. I've detected it because I have a fix for bug#1433 that works before your changes, but does not work afterwards. I'm testing by adding the following line to Fw32_short_file_name: filename = ENCODE_FILE (filename); before the call to GetShortPathName. Before your changes, 1783 filename = ENCODE_FILE (filename); (gdb) p filename $5 = 52759907 (gdb) xstring $6 = (struct Lisp_String *) 0x3250d60 "c:/acci\303\263n/" (gdb) next 1786 if (GetShortPathName (SDATA (filename), shortname, MAX_PATH) == 0) (gdb) p filename $7 = 52759971 (gdb) xstring $8 = (struct Lisp_String *) 0x3250da0 "c:/acci\363n/" After your changes, 1783 filename = ENCODE_FILE (filename); (gdb) p filename $5 = 55776275 (gdb) xstring $6 = (struct Lisp_String *) 0x3531410 "c:/acci\303\263n/" (gdb) next 1786 if (GetShortPathName (SDATA (filename), shortname, MAX_PATH) == 0) (gdb) p filename $7 = 55776339 (gdb) xstring $8 = (struct Lisp_String *) 0x3531450 "c:/acci n/" Juanma