From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.bugs Subject: bug#1259: quit-window does not kill the window Date: Fri, 14 Nov 2008 10:36:00 +0100 Message-ID: References: <491D318C.80402@gmx.at> Reply-To: Juanma Barranquero , 1259@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1226656245 22017 80.91.229.12 (14 Nov 2008 09:50:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Nov 2008 09:50:45 +0000 (UTC) Cc: 1259@emacsbugs.donarmstrong.com To: "martin rudalics" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 14 10:51:45 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0vL7-0004jy-1Z for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Nov 2008 10:51:45 +0100 Original-Received: from localhost ([127.0.0.1]:55740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0vJz-0006sG-0q for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Nov 2008 04:50:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0vJd-0006mH-Dt for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2008 04:50:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0vJb-0006le-SL for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2008 04:50:12 -0500 Original-Received: from [199.232.76.173] (port=55367 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0vJb-0006lW-JG for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2008 04:50:11 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50334) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L0vJa-0001Vt-R3 for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2008 04:50:11 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAE9o7Th005306; Fri, 14 Nov 2008 01:50:08 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mAE9j3Y6003730; Fri, 14 Nov 2008 01:45:03 -0800 X-Loop: don@donarmstrong.com Resent-From: "Juanma Barranquero" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 14 Nov 2008 09:45:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1259 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1259-submit@emacsbugs.donarmstrong.com id=B1259.12266553652375 (code B ref 1259); Fri, 14 Nov 2008 09:45:03 +0000 Original-Received: (at 1259) by emacsbugs.donarmstrong.com; 14 Nov 2008 09:36:05 +0000 Original-Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAE9a1TE002369 for <1259@emacsbugs.donarmstrong.com>; Fri, 14 Nov 2008 01:36:03 -0800 Original-Received: by ey-out-2122.google.com with SMTP id 4so591182eyf.13 for <1259@emacsbugs.donarmstrong.com>; Fri, 14 Nov 2008 01:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=UWELt5CLnKpOk71/OHeGZY/Y/2pEnbrbQeZ2jr+FvpA=; b=B4DyBgQPlU13Zq8E813uz4KMygudjaOzQF320kxG7nLYjUlRL0v3EFqd95JXdllXMq 0/fPZLQMjBd03S318LSVUMckDO1FO4y/XbYmS3t0oH/NLsEDuB+JvghxRAYgRfg71XdM wxGKUbyFG+rKnn0KoCMfj8bImvu/F5eOlm2KI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=bDBlKKtw4u5EaGfQGnzqT8zSwFK2PdSFkL64LWtrT0+4jVy10G1UnDvl6jfBdCagd8 /0jnGI/2FoidOMasBduQTgGnTR1jxmKXS/osoIxNPFuwChR2YVd31SYdm4KqIYD6otyz ZHSfgn+3CRBB4xifiXYbNjD2xauNgevk58bwg= Original-Received: by 10.210.67.4 with SMTP id p4mr849727eba.20.1226655360964; Fri, 14 Nov 2008 01:36:00 -0800 (PST) Original-Received: by 10.210.23.12 with HTTP; Fri, 14 Nov 2008 01:36:00 -0800 (PST) In-Reply-To: Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 14 Nov 2008 04:50:12 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22336 Archived-At: On Fri, Nov 14, 2008 at 10:19, Juanma Barranquero wrote: > Yes, it works as expected now. To add more information: the difference in behavior between your committed patch (let's call it v1) and the one you just sent (v2) is related to defaulting to the selected window. I mean, with the following defun (defun my-quit-window () (interactive) (quit-window nil (selected-window))) and testing with emacs -Q C-h N M-x occur emacs C-x o M-x quit-window ;; or M-x my-quit-window In 22.X: M-x quit-window => buries the buffer, keeps the window M-x my-quit-window => buries the buffer, kills the window In 23.X, v1 M-x quit-window => buries the buffer, keeps the window M-x my-quit-window => buries the buffer, keeps the window In 23.X, v2 M-x quit-window => buries the buffer, kills the window M-x my-quit-window => buries the buffer, kills the window So, basically the original `quit-window' had two different behaviors, while your patches just have one. Personally, I'm happy with the "kills the window" behavior, so v2 works for me. But perhaps other people expects quit-window to behave as it did in 22.X. Juanma