From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: emacsclient's option decoding code Date: Tue, 11 Nov 2008 00:33:16 +0100 Message-ID: References: <87d4h377i5.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1226360017 27512 80.91.229.12 (10 Nov 2008 23:33:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Nov 2008 23:33:37 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Chong Yidong" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 11 00:34:38 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KzgHD-0003l2-47 for ged-emacs-devel@m.gmane.org; Tue, 11 Nov 2008 00:34:37 +0100 Original-Received: from localhost ([127.0.0.1]:48574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzgG3-0006zL-HP for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2008 18:33:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KzgG0-0006zG-K7 for emacs-devel@gnu.org; Mon, 10 Nov 2008 18:33:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KzgG0-0006z4-6M for emacs-devel@gnu.org; Mon, 10 Nov 2008 18:33:20 -0500 Original-Received: from [199.232.76.173] (port=55030 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzgG0-0006z1-0w for emacs-devel@gnu.org; Mon, 10 Nov 2008 18:33:20 -0500 Original-Received: from yw-out-1718.google.com ([74.125.46.156]:20748) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KzgFz-0005QH-E8 for emacs-devel@gnu.org; Mon, 10 Nov 2008 18:33:20 -0500 Original-Received: by yw-out-1718.google.com with SMTP id 9so1113562ywk.66 for ; Mon, 10 Nov 2008 15:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=d+UEPn9Q/9Oep2DK8JWRdGClfGnobVbyMtTYJXMC7QQ=; b=XlelI3VfQt+4Y2T7snLpozQrYD+iNloSf3VUssLENHfsup/mK6dCsipN9DGjS3CWcO tExPFTpIrZUyYlaCfGWGyiCv9x+Ko+zhjjWDD8Ha/sQSs0S4CWbCOdczSVGyegWmivBQ 2OWOl5R0yHwXLTBbZaICuIb3hHPl6cs7mWUBM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=QPR3fVkagnG7JRclAC9zu2ZuLTcLs7F9qGCJvNSlYPQwQY2qdhCgdZoSJnKtSsMhYM QaslJLtAJ5/rMftbUWgpfApKErPTxwEHYQsJapfoAj4VOCI+vQ4vsCozK7NlzshMQgWS cQ0wQl0RBcifBF7yXIqQbxEEGkRmsF8zu9V18= Original-Received: by 10.100.32.6 with SMTP id f6mr2461464anf.87.1226359996797; Mon, 10 Nov 2008 15:33:16 -0800 (PST) Original-Received: by 10.100.13.13 with HTTP; Mon, 10 Nov 2008 15:33:16 -0800 (PST) In-Reply-To: <87d4h377i5.fsf@cyd.mit.edu> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105548 Archived-At: On Mon, Nov 10, 2008 at 19:36, Chong Yidong wrote: >> - (make-frame-on-display nil ...) is a synonym of (make-frame ...), >> but only on Windows; I proposed patch (2). Does anyone see a problem >> with it? > > These two patches look OK to me. Well, it's worse than that, because with your change to `make-frame-on-display', (make-frame-on-display "") works on Windows; in fact, that's what `server-create-window-system-frame' uses, because on Windows, (frame-parameter nil 'display) => "" With my patch, "" would not be accepted, because it is obviously not null. We'd have to use ((or (null display) (eq system-type 'windows-nt)) (make-frame parameters)) which is progressively uglier. All in all, I think accepting anything as DISPLAY for Windows is a bad choice. If we're going that route, it'd be cleaner to accept only nil as default display, and fix the callers to use nil for "" on Windows. Juanma