From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: cyd@stupidchicken.com, emacs-devel@gnu.org
Subject: Re: emacsclient's option decoding code
Date: Mon, 10 Nov 2008 19:22:08 +0100 [thread overview]
Message-ID: <f7ccd24b0811101022y72c3fc32x32d9b08b91f8ac98@mail.gmail.com> (raw)
In-Reply-To: <f7ccd24b0811070642h59b2bffn6b3dedf0943a3377@mail.gmail.com>
Summary of pending issues in this thread:
- emacsclient -t causes a crash / assertion error; filed as bug#1325.
- emacsclient -c causes the same error, because emacsclient thinks
that "-c" + null DISPLAY => "-t"; I proposed the attached patch (1),
because even if -t is supported on Windows, the assumption that an
empty DISPLAY implies a tty frame is false.
- (make-frame-on-display nil ...) is a synonym of (make-frame ...),
but only on Windows; I proposed patch (2). Does anyone see a problem
with it?
- Regardless of whether the previous point is accepted or not, the
new behavior should be documented.
Juanma
Patch (1):
Index: lib-src/emacsclient.c
===================================================================
RCS file: /sources/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.140
diff -u -2 -b -r1.140 emacsclient.c
--- lib-src/emacsclient.c 2 Nov 2008 23:16:33 -0000 1.140
+++ lib-src/emacsclient.c 3 Nov 2008 11:37:19 -0000
@@ -575,7 +575,9 @@
display = NULL;
+#ifndef WINDOWSNT
/* If no display is available, new frames are tty frames. */
if (!current_frame && !display)
tty = 1;
+#endif
Patch (2):
Index: lisp/frame.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/frame.el,v
retrieving revision 1.289
diff -u -2 -r1.289 frame.el
--- lisp/frame.el 7 Nov 2008 14:52:04 -0000 1.289
+++ lisp/frame.el 10 Nov 2008 18:17:48 -0000
@@ -609,4 +609,5 @@
(defun make-frame-on-display (display &optional parameters)
"Make a frame on display DISPLAY.
+If DISPLAY is nil, default to the current display.
The optional argument PARAMETERS specifies additional frame parameters."
(interactive "sMake frame on display: ")
@@ -617,6 +618,5 @@
(make-frame `((window-system . ns)
(display . ,display) . ,parameters)))
- ((eq system-type 'windows-nt)
- ;; On Windows, ignore DISPLAY.
+ ((null display)
(make-frame parameters))
(t
next prev parent reply other threads:[~2008-11-10 18:22 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 14:04 emacsclient's option decoding code Eli Zaretskii
2008-11-02 2:13 ` Stefan Monnier
2008-11-02 21:45 ` Chong Yidong
2008-11-02 22:00 ` Juanma Barranquero
2008-11-02 23:18 ` Chong Yidong
2008-11-03 0:50 ` Juanma Barranquero
2008-11-03 4:14 ` Eli Zaretskii
2008-11-03 12:12 ` Juanma Barranquero
2008-11-03 20:06 ` Eli Zaretskii
2008-11-03 20:19 ` Chong Yidong
2008-11-04 4:20 ` Eli Zaretskii
2008-11-04 16:40 ` Chong Yidong
2008-11-06 11:56 ` Juanma Barranquero
2008-11-03 21:26 ` Juanma Barranquero
2008-11-04 4:19 ` Eli Zaretskii
2008-11-06 12:08 ` Juanma Barranquero
2008-11-07 9:53 ` Eli Zaretskii
2008-11-07 11:42 ` Juanma Barranquero
2008-11-07 11:47 ` Juanma Barranquero
2008-11-07 14:36 ` Eli Zaretskii
2008-11-07 14:42 ` Juanma Barranquero
2008-11-10 18:22 ` Juanma Barranquero [this message]
2008-11-10 18:36 ` Chong Yidong
2008-11-10 23:33 ` Juanma Barranquero
2008-11-11 4:09 ` Eli Zaretskii
2008-11-11 4:14 ` Chong Yidong
2008-11-11 21:16 ` Eli Zaretskii
2008-11-11 9:39 ` Juanma Barranquero
2008-11-11 15:37 ` Juanma Barranquero
2008-11-11 21:24 ` Eli Zaretskii
2008-11-11 23:36 ` Juanma Barranquero
2008-11-12 4:22 ` Eli Zaretskii
2008-11-12 9:41 ` Juanma Barranquero
2008-11-12 19:14 ` Eli Zaretskii
2008-11-12 21:05 ` Juanma Barranquero
2008-11-13 4:12 ` Eli Zaretskii
2008-11-13 8:34 ` Juanma Barranquero
2008-11-12 19:37 ` Eli Zaretskii
2008-11-12 2:31 ` Stefan Monnier
2008-11-12 9:33 ` Juanma Barranquero
2008-11-12 15:56 ` Stefan Monnier
2008-11-12 16:37 ` Juanma Barranquero
2008-11-12 17:13 ` Stefan Monnier
2008-11-13 1:16 ` Lennart Borgman
2008-11-13 4:18 ` Eli Zaretskii
2008-11-13 9:00 ` Juanma Barranquero
2008-11-13 15:45 ` Dan Nicolaescu
2008-11-13 16:05 ` Juanma Barranquero
2008-11-13 16:05 ` Juanma Barranquero
2008-11-13 16:08 ` Dan Nicolaescu
2008-11-12 19:36 ` Eli Zaretskii
2008-11-12 20:56 ` Stefan Monnier
2008-11-13 4:10 ` Eli Zaretskii
2008-11-13 4:29 ` mail
2008-11-13 20:54 ` Eli Zaretskii
2008-11-13 21:27 ` mail
2008-11-13 22:30 ` Eli Zaretskii
2008-11-13 23:54 ` mail
2008-11-13 20:03 ` Juri Linkov
2008-11-13 20:40 ` mail
2008-11-13 21:08 ` Thorsten Bonow
2008-11-13 22:01 ` Thorsten Bonow
2008-11-15 2:58 ` Evil Boris
2008-11-07 14:35 ` Eli Zaretskii
2008-11-03 14:45 ` Juanma Barranquero
2008-11-03 19:59 ` Eli Zaretskii
2008-11-03 20:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0811101022y72c3fc32x32d9b08b91f8ac98@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.