From: "Juanma Barranquero" <lekktu@gmail.com>
To: dhruva <dhruvakm@gmail.com>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: emacsclient on WXP does not work (as it used to)
Date: Fri, 31 Oct 2008 12:02:12 +0100 [thread overview]
Message-ID: <f7ccd24b0810310402v6a2fc2f7x959f0c23dc37806a@mail.gmail.com> (raw)
In-Reply-To: <e3f230850810310335p4397acf5sa90b68b3cba2a9d7@mail.gmail.com>
On Fri, Oct 31, 2008 at 11:35, dhruva <dhruvakm@gmail.com> wrote:
> When I run 'emacsclient some_file' I get the following error even
> though I have a session of emacs running (in window mode)
>
> emacsclient: connect: No connection could be made because the target
> machine actively refused it.
Yes, this change:
http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lib-src/emacsclient.c?r1=1.135&r2=1.136&pathrev=MAIN
is wrong, because on Windows, once inside the if(), tty_name is always
going to be NULL.
I wonder why the whole if isn't just #ifdef'd out. Are there
legitimate uses of tty == 1 on Windows?
The attached patch fixes the problem, but it's ugly as hell.
Juanma
Index: lib-src/emacsclient.c
===================================================================
RCS file: /sources/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.136
diff -u -2 -r1.136 emacsclient.c
--- lib-src/emacsclient.c 30 Oct 2008 15:54:38 -0000 1.136
+++ lib-src/emacsclient.c 31 Oct 2008 11:00:45 -0000
@@ -1441,5 +1441,9 @@
In daemon mode, Emacs may need to occupy this tty if no other
frame is available. */
- if (tty || current_frame)
+ if (tty
+#ifndef WINDOWSNT
+ || current_frame
+#endif
+ )
{
char *type = egetenv ("TERM");
next prev parent reply other threads:[~2008-10-31 11:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 10:35 emacsclient on WXP does not work (as it used to) dhruva
2008-10-31 11:02 ` Juanma Barranquero [this message]
2008-10-31 11:15 ` Eli Zaretskii
2008-10-31 12:27 ` Juanma Barranquero
2008-10-31 12:46 ` dhruva
2008-10-31 12:52 ` dhruva
2008-10-31 12:53 ` Juanma Barranquero
2008-10-31 12:57 ` dhruva
2008-10-31 12:52 ` Juanma Barranquero
2008-10-31 12:58 ` dhruva
2008-10-31 13:10 ` Juanma Barranquero
2008-10-31 13:38 ` dhruva
2008-10-31 13:40 ` dhruva
2008-10-31 14:22 ` Juanma Barranquero
2008-10-31 14:27 ` Juanma Barranquero
2008-10-31 14:29 ` dhruva
2008-10-31 14:13 ` Chong Yidong
2008-10-31 14:14 ` Juanma Barranquero
2008-10-31 14:44 ` Eli Zaretskii
2008-10-31 15:21 ` dhruva
2008-11-01 13:53 ` Eli Zaretskii
2008-11-01 14:55 ` Juanma Barranquero
2008-11-01 16:41 ` Eli Zaretskii
2008-11-01 17:01 ` Eli Zaretskii
2008-11-02 4:03 ` Juanma Barranquero
2008-11-02 4:19 ` Eli Zaretskii
2008-11-01 17:02 ` Eli Zaretskii
2008-11-02 2:59 ` dhruva
2008-11-02 4:17 ` Eli Zaretskii
2008-10-31 21:58 ` Andreas Schwab
2008-10-31 14:31 ` Newsticker is jealous Paul R
2008-10-31 14:43 ` Paul R
2008-10-31 17:21 ` Ulf Jasper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0810310402v6a2fc2f7x959f0c23dc37806a@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=dhruvakm@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.