From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: patch to hilight-chg not in emacs 22.1 Date: Fri, 25 Apr 2008 16:27:37 +0200 Message-ID: References: <7C11E945-3ED3-45A0-A3D2-1F700D12BC9B@pobox.com> <8CB2E924-9CF1-4312-911C-1DA4783D19FD@pobox.com> <1DEEFF6E-3F47-47FE-82AC-AFFA68D3F7FF@pobox.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1209133720 28345 80.91.229.12 (25 Apr 2008 14:28:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Apr 2008 14:28:40 +0000 (UTC) Cc: martin rudalics , Emacs Devel , Richard Stallman , Richard Sharman To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 25 16:29:15 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JpOvJ-0007zt-QR for ged-emacs-devel@m.gmane.org; Fri, 25 Apr 2008 16:29:14 +0200 Original-Received: from localhost ([127.0.0.1]:34771 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JpOud-0004Fk-Mr for ged-emacs-devel@m.gmane.org; Fri, 25 Apr 2008 10:28:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JpOtr-0003Vg-Do for emacs-devel@gnu.org; Fri, 25 Apr 2008 10:27:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JpOtp-0003TZ-IE for emacs-devel@gnu.org; Fri, 25 Apr 2008 10:27:42 -0400 Original-Received: from [199.232.76.173] (port=44099 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JpOtp-0003TM-9m for emacs-devel@gnu.org; Fri, 25 Apr 2008 10:27:41 -0400 Original-Received: from el-out-1112.google.com ([209.85.162.178]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JpOto-000342-UY for emacs-devel@gnu.org; Fri, 25 Apr 2008 10:27:41 -0400 Original-Received: by el-out-1112.google.com with SMTP id s27so1572308ele.1 for ; Fri, 25 Apr 2008 07:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=cjdDJSH6cI49hIsErWJopY7ju1/IrTVqKNlz8kyQskY=; b=pD/tDyqAQ2kNCENY9ukwWpgxrn4KMK3UHAJwpqHQ8jrZx6hIcmj+/ZhQcEzTJtSPH9MegR7rjcH0hUY/pjtBlgf5vfMFW8ZinjOINu8UDuQ0cMHc9Isj9VhGpyXOXhoJ46imvVm03fKxuk18eHmPOGrlXYtlVkc9MQRhjU9Ldzw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=bHX4AaWN2B7tdot0lDoYTPkSwqjX3d/LGhr5wkineHFwGdeFvScflcYdLAoG1f6TRwAuHeGWWU4aMJSVLNai4z420Rplp1+qMmHGLjHjmi/vrRm5wme338ZEnHk9zYQPVDgFqcjEHWLu/OkarGPr4sZiYKtSVZeXAxw68WCQSd4= Original-Received: by 10.114.135.1 with SMTP id i1mr3235838wad.88.1209133657078; Fri, 25 Apr 2008 07:27:37 -0700 (PDT) Original-Received: by 10.114.166.20 with HTTP; Fri, 25 Apr 2008 07:27:37 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95941 Archived-At: After this change: 2008-04-03 Richard Sharman * hilit-chg.el (highlight-changes-mode): Rename from highlight-changes; no longer uses sub-modes active and passive; implemented by define-minor-mode. (highlight-changes-toggle-visibility): New function, to replace the old passive/active submodes of global-highlight-changes-mode; implemented by define-minor-mode. (global-highlight-changes-mode): Rename from global-highlight-changes; rewrite using define-globalized-minor-mode. (hilit-chg-major-mode-hook, hilit-chg-check-global) (hilit-chg-post-command-hook, hilit-chg-check-global) (hilit-chg-update-all-buffers, hilit-chg-turn-off-maybe): Remove due to use of define-globalized-minor-mode. (highlight-changes-global-initial-state): Change to be boolean. (highlight-changes-visible-string, highlight-changes-invisible-string): Rename from highlight-changes-active-string and highlight-changes-passive-string. (hilit-chg-update, hilit-chg-set): Use them. (global-highlight-changes-mode): Rename from global-highlight-changes. (hilit-chg-map-changes, hilit-chg-display-changes): Add arguments to docstring. (hilit-chg-hide-changes): Rewrite to use dolist. (hilit-chg-set-face-on-change, hilit-chg-update) (highlight-changes-rotate-faces): Use highlight-changes-visible-mode variable instead of testing highlight-changes-mode. (highlight-markup-buffers): Add require ediff-util; argument on calls to highlight-changes-mode changed. (highlight-compare-with-file): Fix problems with interactive call giving invalid default file. the file comments and the docstring of `highlight-changes-mode' still reference `highlight-changes-disable-hook', which seem not to exist anymore. I suppose that's an oversight and it should be obsoleted? (And also `highlight-changes-enable-hook', which weirdly enough still exists.) Juanma