Crash after latest w32font changes

Crash after latest w32font changes

[Juanma Barranquero]

Program received signal SIGSEGV, Segmentation fault.
recompute_cached_metrics (dc=0xe2010a2f, font=0x1b53800) at w32font.c:1722
1722          if (GetGlyphOutlineW (dc, i + 32, GGO_METRICS
(gdb) bt
#0  recompute_cached_metrics (dc=0xe2010a2f, font=0x1b53800) at w32font.c:1722
#1  0x0120fe61 in w32font_open_internal (f=0x1ab8000,
font_entity=27405252, pixel_size=13, w32_font=0x1b53800) at
w32font.c:784
#2  0x012107a4 in w32font_open (f=0x1ab8000, font_entity=27405252,
pixel_size=13) at w32font.c:205
#3  0x0108054c in font_open_entity (f=0x1ab8000, entity=27405252,
pixel_size=13) at font.c:2502
#4  0x0108b794 in font_open_by_name (f=0x1ab8000, name=0x1947934
"-*-dejavu sans mono-normal-r-normal-*-13-*-*-*-c-*-iso8859-1")
    at font.c:2922
#5  0x0119a388 in x_set_font (f=0x1ab8000, arg=26174019,
oldval=26032129) at frame.c:3392
#6  0x0119a8c3 in x_set_frame_parameters (f=0x1ab8000, alist=40540333)
at frame.c:3022
#7  0x0119b0cf in x_default_parameter (f=0x1ab8000, alist=40540765,
prop=26262465, deflt=26174147, xprop=0x1431792 "font",
    xclass=0x143178d "Font", type=RES_TYPE_STRING) at frame.c:4058
#8  0x011fbde7 in x_default_font_parameter (f=0x1ab8000,
parms=40540765) at w32fns.c:4244
#9  0x012058ba in Fx_create_frame (parameters=40540981) at w32fns.c:4405
#10 0x0101cb1e in Ffuncall (nargs=2, args=0x82f6f4) at eval.c:3025
#11 0x01156a0d in Fbyte_code (bytestr=19228907, vector=19229004,
maxdepth=32) at bytecode.c:679
#12 0x0101c34a in funcall_lambda (fun=19228860, nargs=1,
arg_vector=0x82f824) at eval.c:3212
#13 0x0101c7c8 in Ffuncall (nargs=2, args=0x82f820) at eval.c:3071
#14 0x01156a0d in Fbyte_code (bytestr=19520451, vector=19520596,
maxdepth=48) at bytecode.c:679
#15 0x0101c34a in funcall_lambda (fun=19520404, nargs=1,
arg_vector=0x82f964) at eval.c:3212
#16 0x0101c7c8 in Ffuncall (nargs=2, args=0x82f960) at eval.c:3071
#17 0x01156a0d in Fbyte_code (bytestr=19516547, vector=19516668,
maxdepth=48) at bytecode.c:679
#18 0x0101c34a in funcall_lambda (fun=19516516, nargs=0,
arg_vector=0x82faa4) at eval.c:3212
#19 0x0101c7c8 in Ffuncall (nargs=1, args=0x82faa0) at eval.c:3071
#20 0x01156a0d in Fbyte_code (bytestr=19250683, vector=19251572,
maxdepth=56) at bytecode.c:679
#21 0x0101c34a in funcall_lambda (fun=19250660, nargs=0,
arg_vector=0x82fbe4) at eval.c:3212
#22 0x0101c7c8 in Ffuncall (nargs=1, args=0x82fbe0) at eval.c:3071
#23 0x01156a0d in Fbyte_code (bytestr=19246475, vector=19246692,
maxdepth=48) at bytecode.c:679
#24 0x0101c34a in funcall_lambda (fun=19246452, nargs=0,
arg_vector=0x82fcb0) at eval.c:3212
#25 0x0101c5c4 in apply_lambda (fun=19246452, args=26032129,
eval_flag=1) at eval.c:3136
#26 0x0101b855 in Feval (form=26766533) at eval.c:2398
#27 0x01099a84 in top_level_2 () at keyboard.c:1379
#28 0x0101af97 in internal_condition_case (bfun=0x1099a71
<top_level_2>, handlers=26098809, hfun=0x109e743 <cmd_error>)
    at eval.c:1494
#29 0x0109d919 in top_level_1 () at keyboard.c:1387
#30 0x0101b032 in internal_catch (tag=26091833, func=0x109d8e9
<top_level_1>, arg=26032129) at eval.c:1230
#31 0x0109e55e in command_loop () at keyboard.c:1342
#32 0x0109e8a6 in recursive_edit_1 () at keyboard.c:958
#33 0x0109ea11 in Frecursive_edit () at keyboard.c:1020
#34 0x01002b01 in main (argc=8585136, argv=0xa82750) at emacs.c:1787

Lisp Backtrace:
"x-create-frame" (0x82f6f8)
"x-create-frame-with-faces" (0x82f824)
"make-frame" (0x82f964)
"frame-initialize" (0x82faa4)
"command-line" (0x82fbe4)
"normal-top-level" (0x82fcb0)

-- 
             Juanma

Re: Crash after latest w32font changes

[Juanma Barranquero]

Perhaps it is something as simple as this?

             Juanma


Index: src/w32font.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/w32font.c,v
retrieving revision 1.13
diff -u -2 -r1.13 w32font.c
--- src/w32font.c	3 Mar 2008 00:31:18 -0000	1.13
+++ src/w32font.c	3 Mar 2008 01:16:20 -0000
@@ -1710,5 +1710,5 @@
   MAT2 transform;
   int i;
-  struct w32font_info *w32_font;
+  struct w32font_info *w32_font = (struct w32font_info *) font;

   bzero (&transform, sizeof (transform));

Re: Crash after latest w32font changes

[Jason Rumney]

Juanma Barranquero wrote:
> Perhaps it is something as simple as this?
>
> -  struct w32font_info *w32_font;
> +  struct w32font_info *w32_font = (struct w32font_info *) font;
>   

Thanks, I fixed it a different way without actually noticing that bug.

Re: Crash after latest w32font changes

[Juanma Barranquero]

On Mon, Mar 3, 2008 at 2:51 AM, Jason Rumney <jasonr@gnu.org> wrote:

>  Thanks, I fixed it a different way without actually noticing that bug.

Thanks, it is working now.

             Juanma