* unnecessary (require 'cus-edit) in set-variable?
@ 2007-12-05 19:12 Drew Adams
2007-12-05 21:16 ` Juanma Barranquero
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2007-12-05 19:12 UTC (permalink / raw)
To: Emacs-Devel
The definition of `set-variable' contains this code:
(let ((type (get variable 'custom-type)))
(when type
;; Match with custom type.
(require 'cus-edit)
(setq type (widget-convert type))
(unless (widget-apply type :match value)
(error "Value `%S' does not match type %S of %S"
value (car type) variable))))
I don't understand the (require 'cus-edit), since there is nothing in
cus-edit.el that is called here. Should it be removed? If not, why
is it needed?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: unnecessary (require 'cus-edit) in set-variable? 2007-12-05 19:12 unnecessary (require 'cus-edit) in set-variable? Drew Adams @ 2007-12-05 21:16 ` Juanma Barranquero 2007-12-05 21:20 ` Drew Adams 0 siblings, 1 reply; 4+ messages in thread From: Juanma Barranquero @ 2007-12-05 21:16 UTC (permalink / raw) To: Drew Adams; +Cc: Emacs-Devel On Dec 5, 2007 8:12 PM, Drew Adams <drew.adams@oracle.com> wrote: > I don't understand the (require 'cus-edit), since there is nothing in > cus-edit.el that is called here. This is the ChangeLog entry: 2001-07-16 Gerd Moellmann <gerd@gnu.org> * simple.el (set-variable): Require 'cus-edit' instead of `wid-edit', so that the Custom widgets get defined. Is still relevant? Juanma ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: unnecessary (require 'cus-edit) in set-variable? 2007-12-05 21:16 ` Juanma Barranquero @ 2007-12-05 21:20 ` Drew Adams 2007-12-05 21:56 ` Juanma Barranquero 0 siblings, 1 reply; 4+ messages in thread From: Drew Adams @ 2007-12-05 21:20 UTC (permalink / raw) To: Juanma Barranquero; +Cc: Emacs-Devel > > I don't understand the (require 'cus-edit), since there is nothing in > > cus-edit.el that is called here. > > This is the ChangeLog entry: > > 2001-07-16 Gerd Moellmann <gerd@gnu.org> > > * simple.el (set-variable): Require 'cus-edit' instead of > `wid-edit', so that the Custom widgets get defined. Thanks for tracking that. > Is still relevant? Is what still relevant, Gerd's change or my question/confusion? I don't see how this code works. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: unnecessary (require 'cus-edit) in set-variable? 2007-12-05 21:20 ` Drew Adams @ 2007-12-05 21:56 ` Juanma Barranquero 0 siblings, 0 replies; 4+ messages in thread From: Juanma Barranquero @ 2007-12-05 21:56 UTC (permalink / raw) To: Drew Adams; +Cc: Emacs-Devel On Dec 5, 2007 10:20 PM, Drew Adams <drew.adams@oracle.com> wrote: > Is what still relevant, Gerd's change or my question/confusion? Gerd's change (or requiring wid-edit as was done before it). Juanma ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-05 21:56 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-12-05 19:12 unnecessary (require 'cus-edit) in set-variable? Drew Adams 2007-12-05 21:16 ` Juanma Barranquero 2007-12-05 21:20 ` Drew Adams 2007-12-05 21:56 ` Juanma Barranquero
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.