unnecessary (require 'cus-edit) in set-variable?

unnecessary (require 'cus-edit) in set-variable?

[Drew Adams]

The definition of `set-variable' contains this code:

(let ((type (get variable 'custom-type)))
    (when type
      ;; Match with custom type.
      (require 'cus-edit)
      (setq type (widget-convert type))
      (unless (widget-apply type :match value)
 (error "Value `%S' does not match type %S of %S"
        value (car type) variable))))

I don't understand the (require 'cus-edit), since there is nothing in
cus-edit.el that is called here.  Should it be removed? If not, why
is it needed?

Re: unnecessary (require 'cus-edit) in set-variable?

[Juanma Barranquero]

On Dec 5, 2007 8:12 PM, Drew Adams <drew.adams@oracle.com> wrote:

> I don't understand the (require 'cus-edit), since there is nothing in
> cus-edit.el that is called here.

This is the ChangeLog entry:

2001-07-16  Gerd Moellmann  <gerd@gnu.org>

        * simple.el (set-variable): Require 'cus-edit' instead of
        `wid-edit', so that the Custom widgets get defined.

Is still relevant?

             Juanma

RE: unnecessary (require 'cus-edit) in set-variable?

[Drew Adams]

> > I don't understand the (require 'cus-edit), since there is nothing in
> > cus-edit.el that is called here.
> 
> This is the ChangeLog entry:
> 
> 2001-07-16  Gerd Moellmann  <gerd@gnu.org>
> 
>         * simple.el (set-variable): Require 'cus-edit' instead of
>         `wid-edit', so that the Custom widgets get defined.

Thanks for tracking that.

> Is still relevant?

Is what still relevant, Gerd's change or my question/confusion?

I don't see how this code works.

Re: unnecessary (require 'cus-edit) in set-variable?

[Juanma Barranquero]

On Dec 5, 2007 10:20 PM, Drew Adams <drew.adams@oracle.com> wrote:

> Is what still relevant, Gerd's change or my question/confusion?

Gerd's change (or requiring wid-edit as was done before it).

             Juanma