From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: "simplifications" Date: Mon, 19 Nov 2007 12:02:16 +0100 Message-ID: References: <86ejem1pig.fsf@lola.quinscape.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1195470155 20088 80.91.229.12 (19 Nov 2007 11:02:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2007 11:02:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: "David Kastrup" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 19 12:02:41 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iu4Ok-00060a-NM for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2007 12:02:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iu4OX-00044G-3E for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2007 06:02:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iu4OT-00043J-RA for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:02:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iu4OS-00042t-AW for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:02:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iu4OS-00042q-6r for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:02:20 -0500 Original-Received: from rv-out-0910.google.com ([209.85.198.185]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iu4OR-0007Jg-A8 for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:02:19 -0500 Original-Received: by rv-out-0910.google.com with SMTP id c27so1301839rvf for ; Mon, 19 Nov 2007 03:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=RIWkngifNX+ATdapYvgzwwmnpVbReJeRObP/iwsfDxE=; b=QH9QwFN3+Z0jk2Tsju/ZmzSHCU7Wsx5UTmKajetAsf5HIbgT9zTAZopJuA3oXXqlRit5YC1GkPXunaI7PGsxcfJiXCYdG4351oT0F41LlWXdWrQV0Kfz5BtvW8Csp3KflL/JX/TrPrMPQjiTFW2GT3eNvxPs3u/XbjsKA5kozYg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VNTvD+Ncn4wzy4IEGUbTq39YfLXJWPAU5F2Xp+fCpmgke79CkeYcZ0C+ltOOjfBgiAS5XVH7U+EOQ+zPw/7vGz/xxhlptbEXAPnBliSl7kn32olNL1nUXE6n41MVT784FbL8CU6Xek2V8o8kxEJfTJA/w2Wi5nDA3msc05ZwkYE= Original-Received: by 10.114.154.1 with SMTP id b1mr568946wae.1195470136293; Mon, 19 Nov 2007 03:02:16 -0800 (PST) Original-Received: by 10.114.168.11 with HTTP; Mon, 19 Nov 2007 03:02:16 -0800 (PST) In-Reply-To: <86ejem1pig.fsf@lola.quinscape.zz> Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83633 Archived-At: Two additional comments, BTW: > Could people, before introducing such "optimizations", check the > bytecode? I didn't write "optimization" anywhere in the ChangeLog, because I was not worried about optimization. If you're gonna revert the change, perhaps you'll want also revert the one to ring-member. My version, with catch, is a lot cleaner IMO, but in my extremely informal tests (which I did before commiting) it was about 1,5% slower. I had to go to the hundreds of thousands of ring-member invocations to see the difference, but perhaps that's very significant for you. Juanma