[herring@lanl.gov: Re: desktop.el ugliness]

[herring@lanl.gov: Re: desktop.el ugliness]

[Richard Stallman]

[I sent this message a week ago but did not get a response.]

Would someone please install this in Emacs 22 and the trunk,
then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS autolearn=failed 
	version=3.1.0
In-Reply-To: <E1I968r-0002z2-AO@fencepost.gnu.org>
Date: Thu, 12 Jul 2007 15:29:07 -0700 (PDT)
Subject: Re: desktop.el ugliness
From: "Davis Herring" <herring@lanl.gov>
To: "Richard Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Reply-To: herring@lanl.gov
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1

> desktop-buffer-info refers to the free variable dirname, which comes
> from desktop-save.  Would someone please clean that up?
> Then please ack.

Sorry; `desktop-buffer-info' was once a lambda in `desktop-save', and I
didn't think to separate it cleanly.  Here's a trivial patch which also
corrects the handling of relative names in `desktop-save'.

Davis

2007-07-12  Davis Herring  <herring@lanl.gov>

	* desktop.el (desktop-buffer-info, desktop-save): Use
	`desktop-dirname' instead of `dirname'.

*** desktop.el	12 Jul 2007 16:23:06 -0600	1.112
- --- desktop.el	12 Jul 2007 16:25:35 -0600
***************
*** 652,658 ****
    (set-buffer buffer)
    (list
     ;; basic information
!    (desktop-file-name (buffer-file-name) dirname)
     (buffer-name)
     major-mode
     ;; minor modes
- --- 652,658 ----
    (set-buffer buffer)
    (list
     ;; basic information
!    (desktop-file-name (buffer-file-name) desktop-dirname)
     (buffer-name)
     major-mode
     ;; minor modes
***************
*** 673,679 ****
     buffer-read-only
     ;; auxiliary information
     (when (functionp desktop-save-buffer)
!      (funcall desktop-save-buffer dirname))
     ;; local variables
     (let ((locals desktop-locals-to-save)
  	 (loclist (buffer-local-variables))
- --- 673,679 ----
     buffer-read-only
     ;; auxiliary information
     (when (functionp desktop-save-buffer)
!      (funcall desktop-save-buffer desktop-dirname))
     ;; local variables
     (let ((locals desktop-locals-to-save)
  	 (loclist (buffer-local-variables))
***************
*** 896,902 ****
  		(insert "\n  " (desktop-value-to-string e)))
  	      (insert ")\n\n")))

! 	  (setq default-directory dirname)
  	  (let ((coding-system-for-write 'emacs-mule))
  	    (write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
  	  ;; We remember when it was modified (which is presumably just now).
- --- 896,902 ----
  		(insert "\n  " (desktop-value-to-string e)))
  	      (insert ")\n\n")))

! 	  (setq default-directory desktop-dirname)
  	  (let ((coding-system-for-write 'emacs-mule))
  	    (write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
  	  ;; We remember when it was modified (which is presumably just now).
------- End of forwarded message -------

Re: [herring@lanl.gov: Re: desktop.el ugliness]

[Juanma Barranquero]

On 7/21/07, Richard Stallman <rms@gnu.org> wrote:
> [I sent this message a week ago but did not get a response.]
>
> Would someone please install this in Emacs 22 and the trunk,
> then ack?

It is already installed. I forgot to ack.

             Juanma

[herring@lanl.gov: Re: desktop.el ugliness]

[Richard Stallman]

Would someone please install this in Emacs 22 and the trunk,
then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS autolearn=failed 
	version=3.1.0
In-Reply-To: <E1I968r-0002z2-AO@fencepost.gnu.org>
Date: Thu, 12 Jul 2007 15:29:07 -0700 (PDT)
Subject: Re: desktop.el ugliness
From: "Davis Herring" <herring@lanl.gov>
To: "Richard Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Reply-To: herring@lanl.gov
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1

> desktop-buffer-info refers to the free variable dirname, which comes
> from desktop-save.  Would someone please clean that up?
> Then please ack.

Sorry; `desktop-buffer-info' was once a lambda in `desktop-save', and I
didn't think to separate it cleanly.  Here's a trivial patch which also
corrects the handling of relative names in `desktop-save'.

Davis

2007-07-12  Davis Herring  <herring@lanl.gov>

	* desktop.el (desktop-buffer-info, desktop-save): Use
	`desktop-dirname' instead of `dirname'.

*** desktop.el	12 Jul 2007 16:23:06 -0600	1.112
- --- desktop.el	12 Jul 2007 16:25:35 -0600
***************
*** 652,658 ****
    (set-buffer buffer)
    (list
     ;; basic information
!    (desktop-file-name (buffer-file-name) dirname)
     (buffer-name)
     major-mode
     ;; minor modes
- --- 652,658 ----
    (set-buffer buffer)
    (list
     ;; basic information
!    (desktop-file-name (buffer-file-name) desktop-dirname)
     (buffer-name)
     major-mode
     ;; minor modes
***************
*** 673,679 ****
     buffer-read-only
     ;; auxiliary information
     (when (functionp desktop-save-buffer)
!      (funcall desktop-save-buffer dirname))
     ;; local variables
     (let ((locals desktop-locals-to-save)
  	 (loclist (buffer-local-variables))
- --- 673,679 ----
     buffer-read-only
     ;; auxiliary information
     (when (functionp desktop-save-buffer)
!      (funcall desktop-save-buffer desktop-dirname))
     ;; local variables
     (let ((locals desktop-locals-to-save)
  	 (loclist (buffer-local-variables))
***************
*** 896,902 ****
  		(insert "\n  " (desktop-value-to-string e)))
  	      (insert ")\n\n")))

! 	  (setq default-directory dirname)
  	  (let ((coding-system-for-write 'emacs-mule))
  	    (write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
  	  ;; We remember when it was modified (which is presumably just now).
- --- 896,902 ----
  		(insert "\n  " (desktop-value-to-string e)))
  	      (insert ")\n\n")))

! 	  (setq default-directory desktop-dirname)
  	  (let ((coding-system-for-write 'emacs-mule))
  	    (write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
  	  ;; We remember when it was modified (which is presumably just now).
------- End of forwarded message -------