From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: using empty_string as the only "" string Date: Fri, 8 Jun 2007 17:49:12 +0200 Message-ID: References: <462EE947.000007.15251@camay.yandex.ru> <46330BC7.8040102@yandex.ru> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1181317770 15644 80.91.229.12 (8 Jun 2007 15:49:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 8 Jun 2007 15:49:30 +0000 (UTC) Cc: dmantipov@yandex.ru, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 08 17:49:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HwgiM-00018U-Um for ged-emacs-devel@m.gmane.org; Fri, 08 Jun 2007 17:49:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HwgiM-0006eC-IV for ged-emacs-devel@m.gmane.org; Fri, 08 Jun 2007 11:49:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HwgiH-0006dm-CP for emacs-devel@gnu.org; Fri, 08 Jun 2007 11:49:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HwgiF-0006da-1b for emacs-devel@gnu.org; Fri, 08 Jun 2007 11:49:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HwgiE-0006dV-TO for emacs-devel@gnu.org; Fri, 08 Jun 2007 11:49:18 -0400 Original-Received: from wx-out-0506.google.com ([66.249.82.228]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HwgiD-0005y6-No for emacs-devel@gnu.org; Fri, 08 Jun 2007 11:49:17 -0400 Original-Received: by wx-out-0506.google.com with SMTP id h26so834764wxd for ; Fri, 08 Jun 2007 08:49:16 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=tFPfe7zfo+B5npwhh3SX2tI9hzB4aAQX9gN8j1jUssDOEzFdgr+VRkpEgpsnxwE2EoQgKkUZKd7DydGgLNcOQsmVtjeTnwGCkm1+9pkfkIjS0QTRi4UsEvS4Fah1O9VC2lkXiEKm6PhQlNCmlKcTQhiz0dXhEmhwlhgCBg5OFGE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=SpJnNKRVzyPmOc3bPNKjT3lLX9t36hJZPlOweTCn/qkl6ht+wDss+p8ZxQLi0r81FmSI40GvOSZBkAZspNQiSPY58Yfcfr7ISnrpY9QpIHyu9lmMij3Ug5hqKm/WeOs+hiCDvpTqoRX6hv6Hf3i27HWN9kBhCxQhy93kNIQNt48= Original-Received: by 10.90.106.11 with SMTP id e11mr3089038agc.1181317756364; Fri, 08 Jun 2007 08:49:16 -0700 (PDT) Original-Received: by 10.90.103.8 with HTTP; Fri, 8 Jun 2007 08:49:12 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-detected-kernel: Linux 2.4-2.6 (Google crawlbot) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72500 Archived-At: On 6/7/07, Richard Stallman wrote: > We can scrape by with this new change, but anything more would need > papers. OK, I can install the change. It's less than 40 changed lines, across 18 files, and a 20% of those changes are simply the renaming empty_string => empty_unibyte_string. Of the rest, most are using empty_unibyte_string instead of make_string ("", 0) or build_string (""). BTW, I see no consistency in the way empty_string was used before: at times empty_string was used, others make_string ("", 0) or build_string ("") were preferred. That causes this funny equality: ;; without the patch (eq "" "") => nil (eq (car (car (cdr (cdr icon-title-format)))) (key-description "")) => t which I suppose more than offsets my unhappiness for this: ;; with the patch (eq "" (substring-no-properties "" 0 0)) => t and the slight incompatibility that (condition-case err (store-substring "" 0 "a") (error err)) => (args-out-of-range "" 0) ; before the patch => (error "Attempt to modify read-only object") ; after the patch Warning: the patch changes lisp.h and most src/*.c files do not have a makefile dependency for it, so I suspect a full recompilation (or a bootstrap) will be needed after the patch. Juanma