From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: unload-feature questions and thoughts Date: Mon, 5 Feb 2007 12:08:28 +0100 Message-ID: References: <85bqk9db9a.fsf@lola.goethe.zz> <851wl5d9b2.fsf@lola.goethe.zz> <86r6t5qdbo.fsf@lola.quinscape.zz> <861wl5q7al.fsf@lola.quinscape.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1170673875 13577 80.91.229.12 (5 Feb 2007 11:11:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 5 Feb 2007 11:11:15 +0000 (UTC) Cc: Emacs Devel To: "David Kastrup" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 05 12:11:09 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HE1ka-0000C8-MF for ged-emacs-devel@m.gmane.org; Mon, 05 Feb 2007 12:11:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HE1kZ-0004oI-8T for ged-emacs-devel@m.gmane.org; Mon, 05 Feb 2007 06:11:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HE1i6-0004GR-CU for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:08:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HE1i3-0004F0-OQ for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:08:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HE1i2-0004EF-6f for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:08:30 -0500 Original-Received: from an-out-0708.google.com ([209.85.132.242]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HE1i1-0005bo-Pl for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:08:29 -0500 Original-Received: by an-out-0708.google.com with SMTP id b8so861986ana for ; Mon, 05 Feb 2007 03:08:29 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=uO3xL8IQtMXl6betGjRZZI6hx/mOcgVEMFxfi09RRaOrXjnrtESpNMnP6yCeEZRH78ux4nQh/cayKM0V1Xu13ACXzNPlfcRxwrzDqZSgScvsjjlzsgth5IRO5QpcLuTs3L0hGKMh6m6bDOkpHCS30GkVPP1FlkmAl7wSy0k6RKE= Original-Received: by 10.114.175.16 with SMTP id x16mr579435wae.1170673708717; Mon, 05 Feb 2007 03:08:28 -0800 (PST) Original-Received: by 10.114.234.16 with HTTP; Mon, 5 Feb 2007 03:08:28 -0800 (PST) In-Reply-To: <861wl5q7al.fsf@lola.quinscape.zz> Content-Disposition: inline X-detected-kernel: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65904 Archived-At: On 2/5/07, David Kastrup wrote: > Could you think of something in code or docs that should have > prevented the confusion? I misread the code (I was much more centered in the part about undoing defun, provide, etc. and didn't take a closer look to the beginning of the function), but I think this piece of docstring is a bit confusing This function tries to undo modifications made by the package to hooks. Packages may define a hook FEATURE-unload-hook that is called instead of the normal heuristics for doing this. Such a hook should undo all the relevant global state changes that may have been made by loading the package or executing functions in it. because if you miss the "to hooks" (two words), as I did in several readings, it seems like it is saying that either you define FEATURE-unload-hook, or else it uses "the normal heuristics". /L/e/k/t/u