From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: A few faces.el questions Date: Wed, 31 Jan 2007 20:55:34 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1170273386 4989 80.91.229.12 (31 Jan 2007 19:56:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 31 Jan 2007 19:56:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 31 20:56:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HCLYe-0006ac-Km for ged-emacs-devel@m.gmane.org; Wed, 31 Jan 2007 20:55:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HCLYd-00055n-MK for ged-emacs-devel@m.gmane.org; Wed, 31 Jan 2007 14:55:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HCLYU-00055g-0H for emacs-devel@gnu.org; Wed, 31 Jan 2007 14:55:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HCLYQ-00055H-Hp for emacs-devel@gnu.org; Wed, 31 Jan 2007 14:55:41 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HCLYQ-00055E-CR for emacs-devel@gnu.org; Wed, 31 Jan 2007 14:55:38 -0500 Original-Received: from an-out-0708.google.com ([209.85.132.240]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HCLYP-0007B0-0H for emacs-devel@gnu.org; Wed, 31 Jan 2007 14:55:37 -0500 Original-Received: by an-out-0708.google.com with SMTP id b8so177243ana for ; Wed, 31 Jan 2007 11:55:35 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=nvjCnFm8HB24yN32LxGOFup3kD1HuBoi/Bs2LNAOCAqgWDlIfqN4uspg1NpiZS3AMw178w1PNpAR9BjDzIqWZcbwU9+lbjn8yyW4pALCOa/bkf6Ktmh7IMMM2GHgRwP4kkDkOoVGIhDSlkUR0e+bBzNPyGmxVrdT7QwStlkvBDo= Original-Received: by 10.114.25.3 with SMTP id 3mr83849way.1170273334629; Wed, 31 Jan 2007 11:55:34 -0800 (PST) Original-Received: by 10.115.93.4 with HTTP; Wed, 31 Jan 2007 11:55:34 -0800 (PST) In-Reply-To: Content-Disposition: inline X-detected-kernel: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65719 Archived-At: On 1/31/07, Drew Adams wrote: > I think he's talking about renaming the argument, not the function. Yes, of course. I want to rename the argument of `set-face-underline-p' (and `modify-face'). I usually wouldn't have asked just to change this; but sometimes people complains when arguments are changed, and in this case `set-face-underline-p' is part of a family of functions, all of which have arguments like BOLD-P, ITALIC-P, etc. But these really are boolean, so clarity and correctness should weight more than (pseudo-)consistency. > BTW, in my version (from 2007-01-25), the arg name in the signature is > `underline-p', but it is referred to in the doc string as UNDERLINE. Yes, that's how I found the problem. It's not a typo in the docstring, but the result of conflating two previous defuns, one of them `set-face-underline', without -p (which had a non-flag UNDERLINE argument), the other named `set-face-underline-p' and with a boolean UNDERLINE-P argument. /L/e/k/t/u