From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: Image autodetection Date: Tue, 30 Jan 2007 16:59:09 +0100 Message-ID: References: <878xflr6vd.fsf@stupidchicken.com> <45BF0A1B.70202@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1170173522 10456 80.91.229.12 (30 Jan 2007 16:12:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 30 Jan 2007 16:12:02 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org, Jason Rumney To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 30 17:11:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HBvOG-0004Eu-3m for ged-emacs-devel@m.gmane.org; Tue, 30 Jan 2007 16:59:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HBvOF-0004sy-QB for ged-emacs-devel@m.gmane.org; Tue, 30 Jan 2007 10:59:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HBvO4-0004ss-Q2 for emacs-devel@gnu.org; Tue, 30 Jan 2007 10:59:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HBvO2-0004sf-QU for emacs-devel@gnu.org; Tue, 30 Jan 2007 10:59:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HBvO2-0004sc-Ls for emacs-devel@gnu.org; Tue, 30 Jan 2007 10:59:10 -0500 Original-Received: from an-out-0708.google.com ([209.85.132.250]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HBvO2-0005g8-5z for emacs-devel@gnu.org; Tue, 30 Jan 2007 10:59:10 -0500 Original-Received: by an-out-0708.google.com with SMTP id b8so693266ana for ; Tue, 30 Jan 2007 07:59:09 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Mk53HZTlHKL6NauWAhXUfUY2/xsFJYDCmYIx5EM8pQSot7ExHCsKjV6/0qR7hRlPA4teWazzM/rvz5HOABahOaH6UiHFJgOAxRW8kK0TrTC9NsPTljw3ifSafb4bAhMSNmfvkuw+w+VZdHwP8PSSzvwsLZfLm2Uiz6MuPxWG7nk= Original-Received: by 10.114.107.19 with SMTP id f19mr46425wac.1170172749130; Tue, 30 Jan 2007 07:59:09 -0800 (PST) Original-Received: by 10.115.93.4 with HTTP; Tue, 30 Jan 2007 07:59:09 -0800 (PST) In-Reply-To: Content-Disposition: inline X-detected-kernel: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65641 Archived-At: On 1/30/07, Stefan Monnier wrote: > Actually, the way I see it the only real advantage of image-minor-mode is > that if a C file gets wrongly detected as a GIF file, it doesn't really > matter because the C mode is still activated and you just get a bunch of > spurious extra commands to display the "image". That would be a different change. As it is now, if we just change `image-mode' to `image-minor-mode' in `magic-mode-alist' (as was done in a previous proposed patch, now rejected), image files would be opened in fundamental mode + image minor mode, because as soon as a non-nil mode is returned when searching in `magic-mode-alist' the detection of major mode is finished (and so `auto-mode-alist' is bypassed). At least, that's what I remember from a test I did. > Looks good to me. Great. /L/e/k/t/u