all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: Chong Yidong <cyd@stupidchicken.com>,
	emacs-devel@gnu.org, Jason Rumney <jasonr@gnu.org>
Subject: Re: Image autodetection
Date: Tue, 30 Jan 2007 16:59:09 +0100	[thread overview]
Message-ID: <f7ccd24b0701300759v5a5c6bta978fc84f8d2e5a6@mail.gmail.com> (raw)
In-Reply-To: <jwvbqkgbl4n.fsf-monnier+emacs@gnu.org>

On 1/30/07, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Actually, the way I see it the only real advantage of image-minor-mode is
> that if a C file gets wrongly detected as a GIF file, it doesn't really
> matter because the C mode is still activated and you just get a bunch of
> spurious extra commands to display the "image".

That would be a different change. As it is now, if we just change
`image-mode' to `image-minor-mode' in `magic-mode-alist' (as was done
in a previous proposed patch, now rejected), image files would be
opened in fundamental mode + image minor mode, because as soon as a
non-nil mode is returned when searching in `magic-mode-alist' the
detection of major mode is finished (and so `auto-mode-alist' is
bypassed). At least, that's what I remember from a test I did.

> Looks good to me.

Great.

                    /L/e/k/t/u

  reply	other threads:[~2007-01-30 15:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29 19:05 Image autodetection Chong Yidong
2007-01-29 19:19 ` Juanma Barranquero
2007-01-30  9:04   ` Jason Rumney
2007-01-30  9:38     ` Juanma Barranquero
2007-01-30 12:11       ` Juanma Barranquero
2007-01-30 15:24         ` Stefan Monnier
2007-01-30 15:59           ` Juanma Barranquero [this message]
2007-01-30 16:54             ` Jason Rumney
2007-01-30 17:07               ` Juanma Barranquero
2007-01-30 16:58         ` Chong Yidong
2007-01-29 23:53 ` Richard Stallman
2007-01-30  0:55 ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0701300759v5a5c6bta978fc84f8d2e5a6@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=jasonr@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.