From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/lib-src/makefile.w32-in,v Date: Mon, 27 Nov 2006 17:20:55 +0100 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1164644804 3114 80.91.229.2 (27 Nov 2006 16:26:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Nov 2006 16:26:44 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 27 17:26:43 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GojJF-00068W-BI for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 17:26:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GojJE-0002Jc-Qi for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 11:26:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GojE5-0006eT-Ob for emacs-devel@gnu.org; Mon, 27 Nov 2006 11:21:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GojE2-0006aD-KD for emacs-devel@gnu.org; Mon, 27 Nov 2006 11:20:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GojE2-0006Zo-3T for emacs-devel@gnu.org; Mon, 27 Nov 2006 11:20:58 -0500 Original-Received: from [66.249.92.171] (helo=ug-out-1314.google.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GojE1-0007kz-Od for emacs-devel@gnu.org; Mon, 27 Nov 2006 11:20:57 -0500 Original-Received: by ug-out-1314.google.com with SMTP id j3so1264114ugf for ; Mon, 27 Nov 2006 08:20:56 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=aKOdKUnc5DscltbyhvlbjNmZJmnbaQ62Vc3xe7Pc+ZHj5uc3vSoUu8G9UlJUySPzXgzBhLdwC13oV+4fGU6hQNUwoK7OPcOVGCxnlYQLmQfbEZWsBaD9l4uXMAEGpHMBK/mDbdTdSU9S/Xt2YV/2H5fejAT3AMqXeuLK3JHS5Kc= Original-Received: by 10.82.118.2 with SMTP id q2mr2045002buc.1164644456121; Mon, 27 Nov 2006 08:20:56 -0800 (PST) Original-Received: by 10.82.147.2 with HTTP; Mon, 27 Nov 2006 08:20:55 -0800 (PST) Original-To: "Eli Zaretskii" In-Reply-To: Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62864 Archived-At: On 11/27/06, Eli Zaretskii wrote: > That'd be a nuisance, I think: people run configure even if > makefile.w32-in didn't change (well, I do), just to be sure. The only (tiny) problem with depending on makefile.w32-in, is that if the user forgets to run configure, he will see emacsclient being compiled, but the version number will still be old. It's a bit misleading. Just a nitpick, anyway. The main case to consider is whether users (not developers building from the CVS tree) will get the right number after bootstrapping the first time, and they will. > What you are actually saying is that makefile in each directory should > depend on the respective makefile.w32-in, and if the latter was > changed, nt/configure.bat should run automatically. A rule in makefile making it depend on makefile.w32-in? Nice idea :) > You are probably > right, but let's not do this before the release. No, of course not! > (While at that, we should also avoid recreating makefile's and other > files produced by nt/configure.bat if the new version would be > identical to the old one, to avoid unnecessary recompilation.) That shouldn't be too tricky, if you can count on a reliable way to compare the old and new files. (Do we require diff right now? I don't think so.) /L/e/k/t/u