all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Juanma Barranquero" <lekktu@gmail.com>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: find-library-name fails if file (with no extension) exists.
Date: Wed, 22 Nov 2006 13:14:27 +0100	[thread overview]
Message-ID: <f7ccd24b0611220414i6085938esd4b3547bfe096332@mail.gmail.com> (raw)
In-Reply-To: <87vel8549g.fsf@pacem.orebokech.com>

On 11/22/06, Romain Francoise <romain@orebokech.com> wrote:

> As noted in <8764d8u085.fsf@pacem.orebokech.com>:
>
>     Note that the same problem existed before my change with files
>     ending in ".elc".
>
> This problem is still there, since I just reverted my change.
>
> But frankly, I doubt it'll bother anyone.

This simple patch does fix the problem. Am I overlooking something
obvious? (The patch is really one-line; the change in the regexp is
just to remove leftover parentheses.)

                    /L/e/k/t/u



Index: lisp/emacs-lisp/find-func.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/find-func.el,v
retrieving revision 1.78
diff -u -2 -r1.78 find-func.el
--- lisp/emacs-lisp/find-func.el	21 Nov 2006 20:06:53 -0000	1.78
+++ lisp/emacs-lisp/find-func.el	22 Nov 2006 12:05:07 -0000
@@ -150,6 +150,6 @@
   ;; If the library is byte-compiled, try to find a source library by
   ;; the same name.
-  (if (string-match "\\.el\\(c\\(\\..*\\)?\\)\\'" library)
-      (setq library (replace-match "" t t library)))
+  (if (string-match "\\.elc\\(\\..*\\)?\\'" library)
+      (setq library (replace-match ".el" t t library)))
   (or (locate-file library
 		   (or find-function-source-path load-path)

  reply	other threads:[~2006-11-22 12:14 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21 16:22 find-library-name fails if file (with no extension) exists Juanma Barranquero
2006-11-21 18:24 ` Romain Francoise
2006-11-21 19:09   ` Juanma Barranquero
2006-11-21 20:07     ` Romain Francoise
2006-11-21 21:58       ` Juanma Barranquero
2006-11-22  7:28         ` Romain Francoise
2006-11-22 12:14           ` Juanma Barranquero [this message]
2006-11-22 12:35             ` Juanma Barranquero
2006-11-22 13:54             ` Romain Francoise
     [not found]               ` <f7ccd24b0611220644m1d8944dq5943175c347cde3e@mail.gmail.com>
2006-11-22 19:34                 ` Juanma Barranquero
2006-11-22 19:47                   ` Romain Francoise
2006-11-22 20:33                     ` Lennart Borgman
2006-11-22 21:02                       ` Juanma Barranquero
2006-11-21 20:07     ` Eli Zaretskii
2006-11-21 20:47     ` Andreas Schwab
2006-11-21 21:04       ` Lennart Borgman
2006-11-21 21:47       ` Juanma Barranquero
2006-11-21 21:48         ` Juanma Barranquero
2006-11-21 22:23         ` David Kastrup
2006-11-21 22:57           ` Juanma Barranquero
2006-11-21 23:19             ` David Kastrup
2006-11-21 23:25               ` Lennart Borgman
2006-11-21 23:33                 ` David Kastrup
2006-11-21 23:36                   ` Juanma Barranquero
2006-11-22  0:16                   ` Lennart Borgman
2006-11-22  0:47                     ` David Kastrup
2006-11-22  0:59                       ` Lennart Borgman
2006-11-22  1:04                         ` David Kastrup
2006-11-22  1:27                           ` Lennart Borgman
2006-11-22  1:56                             ` David Kastrup
2006-11-22  4:25                           ` Eli Zaretskii
2006-11-22  9:37                             ` Juanma Barranquero
2006-11-22 10:05                             ` David Kastrup
2006-11-22 18:44                               ` Eli Zaretskii
2006-11-22  4:22                       ` Eli Zaretskii
2006-11-22 10:03                         ` David Kastrup
2006-11-22 12:07                           ` Lennart Borgman
2006-11-22 12:46                             ` David Kastrup
2006-11-22 21:56                               ` Eli Zaretskii
2006-11-22 22:06                                 ` David Kastrup
2006-11-22 22:33                                   ` Eli Zaretskii
2006-11-23 19:47                                     ` Jan Djärv
2006-11-22 18:40                           ` Eli Zaretskii
2006-11-22 19:13                             ` David Kastrup
2006-11-22 22:04                               ` Eli Zaretskii
2006-11-22  4:17                   ` Eli Zaretskii
2006-11-21 23:34               ` Juanma Barranquero
2006-11-21 23:52                 ` David Kastrup
2006-11-22  0:01                   ` Juanma Barranquero
2006-11-22  0:34                     ` David Kastrup
2006-11-22  0:38                       ` Juanma Barranquero
2006-11-22  9:53                       ` Andreas Schwab
2006-11-22  4:14               ` Eli Zaretskii
2006-11-22  9:53                 ` David Kastrup
2006-11-22 18:38                   ` Eli Zaretskii
2006-11-22 19:27                     ` David Kastrup
2006-11-22 22:09                       ` Eli Zaretskii
2006-11-22 22:18                         ` David Kastrup
2006-11-22 13:16             ` Richard Stallman
2006-11-22 14:48               ` Juanma Barranquero
2006-11-24 22:49                 ` Richard Stallman
2006-11-22  4:10           ` Eli Zaretskii
2006-11-22  9:35             ` David Kastrup
2006-11-22 18:43               ` Eli Zaretskii
2006-11-22 19:25                 ` David Kastrup
2006-11-27 19:32               ` Stuart D. Herring
2006-11-27 19:06             ` Stuart D. Herring
2006-11-28 19:19               ` Eli Zaretskii
2006-11-21 20:06   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0611220414i6085938esd4b3547bfe096332@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.