all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Juanma Barranquero" <lekktu@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: message's docstring
Date: Sun, 12 Nov 2006 13:42:20 +0100	[thread overview]
Message-ID: <f7ccd24b0611120442m5132385fx92ce4886480ff086@mail.gmail.com> (raw)
In-Reply-To: <85zmawyhj6.fsf@lola.goethe.zz>

On 11/12/06, David Kastrup <dak@gnu.org> wrote:

> We should not try accommodating obvious bugs, but rather fix them.  Do
> you have any instances where the return value of `message' would
> actually get used without `message' being confused for `format'?

The one that prompted me to look: in server.el there are cases like

  (server-log (message "Restarting server"))

to avoid

  (message "Restarting server")
  (server-log "Restarting server")

or a `let'. Not earthshaking, but useful.

But, as I said, the intended return of the message in `message' is
*quite* intentional:

  if (NILP (args[0])
      || (STRINGP (args[0])
	  && SBYTES (args[0]) == 0))
    {
      message (0);
      return args[0];
    }
  else
    {
      register Lisp_Object val;
      val = Fformat (nargs, args);
      message3 (val, SBYTES (val), STRING_MULTIBYTE (val));
      return val;
    }

I vote for keeping it and documenting it. Is a one-line in the
docstring, and the current behavior is at least fifteen years old.

                    /L/e/k/t/u

  reply	other threads:[~2006-11-12 12:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-12  0:11 message's docstring Juanma Barranquero
2006-11-12 10:16 ` David Kastrup
2006-11-12 12:08   ` Juanma Barranquero
2006-11-12 12:17     ` David Kastrup
2006-11-12 12:20       ` Juanma Barranquero
2006-11-12 12:29         ` David Kastrup
2006-11-12 12:42           ` Juanma Barranquero [this message]
2006-11-13  9:43           ` Richard Stallman
2006-11-13 18:36   ` Kevin Rodgers
2006-11-13 19:04     ` Juanma Barranquero
2006-11-12 21:12 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0611120442m5132385fx92ce4886480ff086@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.