From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Error in add-log-iso8601-time-string Date: Wed, 26 Apr 2006 11:38:10 +0200 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1146044312 7130 80.91.229.2 (26 Apr 2006 09:38:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 26 Apr 2006 09:38:32 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 26 11:38:29 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FYgTb-0004Fo-PC for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2006 11:38:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYgTb-0004bE-7O for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2006 05:38:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FYgTN-0004av-LU for emacs-devel@gnu.org; Wed, 26 Apr 2006 05:38:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FYgTM-0004aR-78 for emacs-devel@gnu.org; Wed, 26 Apr 2006 05:38:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYgTM-0004aO-36 for emacs-devel@gnu.org; Wed, 26 Apr 2006 05:38:12 -0400 Original-Received: from [66.249.92.171] (helo=uproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FYgW0-0005Pf-NU for emacs-devel@gnu.org; Wed, 26 Apr 2006 05:40:56 -0400 Original-Received: by uproxy.gmail.com with SMTP id m2so1120394ugc for ; Wed, 26 Apr 2006 02:38:10 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=BnjU9Em4/vIEjlO+9dNzSLtTJQAhladpTOGDD6NPfi3CVGdKLNdHZX0HkXPN7ITZTmQTRo0/TAOXlCc1wUmymKVKLjKuBaUswOtKYjJpEX92UAXd5r89vnFqnwoISFwnbYULpcNiWGJDvxPoI50Wk5Tvk9ib+PlqCAqIvLPJY9Q= Original-Received: by 10.78.31.18 with SMTP id e18mr319151hue; Wed, 26 Apr 2006 02:38:10 -0700 (PDT) Original-Received: by 10.78.33.18 with HTTP; Wed, 26 Apr 2006 02:38:10 -0700 (PDT) Original-To: "Emacs Devel" , "Stefan Monnier" Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53454 Archived-At: Unless I'm misundertanding something (likely, as the flu is getting the better of me), the recent patch to `add-log-iso8601-time-string' is flawed: (defun add-log-iso8601-time-string () (let ((time (format-time-string "%Y-%m-%d" (eq t add-log-time-zone-rule)= ))) (if add-log-iso8601-with-time-zone (concat time " " (add-log-iso8601-time-zone)) time))) On one hand, when `add-log-time-zone-rule' is t (possible, according to its docstring), `format-time-string' receives t as second argument, which is an error: ELISP> (format-time-string "%Y-%m-%d" t) *** Eval error *** Wrong type argument: listp, t On the other hand, `add-log-iso8601-time-zone has a mandatory TIME argument which is lacking here. -- /L/e/k/t/u