Error in add-log-iso8601-time-string

Error in add-log-iso8601-time-string

[Juanma Barranquero]

Unless I'm misundertanding something (likely, as the flu is getting
the better of me), the recent patch to `add-log-iso8601-time-string'
is flawed:

 (defun add-log-iso8601-time-string ()
   (let ((time (format-time-string "%Y-%m-%d" (eq t add-log-time-zone-rule))))
     (if add-log-iso8601-with-time-zone
         (concat time " " (add-log-iso8601-time-zone))
       time)))

On one hand, when `add-log-time-zone-rule' is t (possible, according
to its docstring), `format-time-string' receives t as second argument,
which is an error:

 ELISP> (format-time-string "%Y-%m-%d" t)
 *** Eval error ***  Wrong type argument: listp, t

On the other hand, `add-log-iso8601-time-zone has a mandatory TIME
argument which is lacking here.

--
                    /L/e/k/t/u

Re: Error in add-log-iso8601-time-string

[Stefan Monnier]

> Unless I'm misundertanding something (likely, as the flu is getting
> the better of me), the recent patch to `add-log-iso8601-time-string'
> is flawed:

>  (defun add-log-iso8601-time-string ()
>    (let ((time (format-time-string "%Y-%m-%d" (eq t add-log-time-zone-rule))))
>      (if add-log-iso8601-with-time-zone
>          (concat time " " (add-log-iso8601-time-zone))
>        time)))

> On one hand, when `add-log-time-zone-rule' is t (possible, according
> to its docstring), `format-time-string' receives t as second argument,
> which is an error:

ELISP> (format-time-string "%Y-%m-%d" t)
>  *** Eval error ***  Wrong type argument: listp, t

> On the other hand, `add-log-iso8601-time-zone has a mandatory TIME
> argument which is lacking here.

Thanks.  It should be fixed now,


        Stefan