all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Juanma Barranquero" <lekktu@gmail.com>
Subject: Error in add-log-iso8601-time-string
Date: Wed, 26 Apr 2006 11:38:10 +0200	[thread overview]
Message-ID: <f7ccd24b0604260238y44bc5703qefaf53660670e1b2@mail.gmail.com> (raw)

Unless I'm misundertanding something (likely, as the flu is getting
the better of me), the recent patch to `add-log-iso8601-time-string'
is flawed:

 (defun add-log-iso8601-time-string ()
   (let ((time (format-time-string "%Y-%m-%d" (eq t add-log-time-zone-rule))))
     (if add-log-iso8601-with-time-zone
         (concat time " " (add-log-iso8601-time-zone))
       time)))

On one hand, when `add-log-time-zone-rule' is t (possible, according
to its docstring), `format-time-string' receives t as second argument,
which is an error:

 ELISP> (format-time-string "%Y-%m-%d" t)
 *** Eval error ***  Wrong type argument: listp, t

On the other hand, `add-log-iso8601-time-zone has a mandatory TIME
argument which is lacking here.

--
                    /L/e/k/t/u

             reply	other threads:[~2006-04-26  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-26  9:38 Juanma Barranquero [this message]
2006-04-26 16:42 ` Error in add-log-iso8601-time-string Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0604260238y44bc5703qefaf53660670e1b2@mail.gmail.com \
    --to=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.