From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: defvars at compile time Date: Fri, 16 Sep 2005 12:48:35 +0200 Message-ID: Reply-To: lekktu@gmail.com NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1126868929 21834 80.91.229.2 (16 Sep 2005 11:08:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 16 Sep 2005 11:08:49 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 16 13:08:47 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EGE3l-0003Oz-Cg for ged-emacs-devel@m.gmane.org; Fri, 16 Sep 2005 13:07:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EGE3k-00025L-L2 for ged-emacs-devel@m.gmane.org; Fri, 16 Sep 2005 07:07:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EGE2v-0001lp-PX for emacs-devel@gnu.org; Fri, 16 Sep 2005 07:06:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EGE2t-0001ju-PK for emacs-devel@gnu.org; Fri, 16 Sep 2005 07:06:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EGDwk-0007kv-4o for emacs-devel@gnu.org; Fri, 16 Sep 2005 06:59:58 -0400 Original-Received: from [64.233.182.204] (helo=nproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EGDlk-0007uW-Hx for emacs-devel@gnu.org; Fri, 16 Sep 2005 06:48:36 -0400 Original-Received: by nproxy.gmail.com with SMTP id n15so164224nfc for ; Fri, 16 Sep 2005 03:48:35 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=Qi6k4/khfj0AOmwgBr5J2+JtdAeAf1eunRgoMNB1bAPC9CSnoGGZJi9hI6InovzGbpdRKBpUsJJqm5JXpwfP2s4NOrtDOfYpfjFSIMDe8bc0UIAKjL1zXsCFkreaB++yva/zFQKJcQ6Z988KK7ehLJkRXpjJIy5/8b5od/lbbnk= Original-Received: by 10.49.5.15 with SMTP id h15mr24968nfi; Fri, 16 Sep 2005 03:48:35 -0700 (PDT) Original-Received: by 10.48.42.13 with HTTP; Fri, 16 Sep 2005 03:48:35 -0700 (PDT) Original-To: Emacs Devel , Carsten Dominik Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42983 Archived-At: (A little comment regarding recent changes by Carsten Dominik to the reftex*.el files.) I've seen that, as part of your changes, you've moved some defvar's I added, wrapping them inside `eval-when-compile'. I much *prefer* that, I dislike them at top level when they're not really defining a variable, just silencing the byte-compiler. That's what I'd do on my own modules. However, I put them at top level (not the reftex*.el variables, but in general) because Richard specifically asked me to do so. I'm not sure whether it is Emacs policy, coding guidelines or a personal preference, though. --=20 /L/e/k/t/u