From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Changing occur-hook to occur-functions Date: Sat, 2 Jul 2005 21:01:13 +0200 Message-ID: References: Reply-To: Juanma Barranquero NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1120331073 8740 80.91.229.2 (2 Jul 2005 19:04:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 2 Jul 2005 19:04:33 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 02 21:04:32 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DonHq-0000QP-BQ for ged-emacs-devel@m.gmane.org; Sat, 02 Jul 2005 21:04:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DonIx-0001ZV-KG for ged-emacs-devel@m.gmane.org; Sat, 02 Jul 2005 15:05:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DonGb-0000mL-BH for emacs-devel@gnu.org; Sat, 02 Jul 2005 15:03:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DonGX-0000le-0H for emacs-devel@gnu.org; Sat, 02 Jul 2005 15:03:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DonGW-0000lA-Cz for emacs-devel@gnu.org; Sat, 02 Jul 2005 15:03:00 -0400 Original-Received: from [64.233.182.199] (helo=nproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DonKC-0001ir-0z for emacs-devel@gnu.org; Sat, 02 Jul 2005 15:06:48 -0400 Original-Received: by nproxy.gmail.com with SMTP id i2so109591nfe for ; Sat, 02 Jul 2005 12:01:13 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VPZQnrCjXsPBPl2Cx3JIrHnZZPhYxAKnFLp2lof2uHGh+GF7N7vfbXM64IYNw6eU6ZaEqnnfum3Ji8uhly4v5o3ixU7q/aFE1X1Bgf8aT0s2UFqZoYf1KQtwiWxor7eVJK/H91OZQrVlTkhCJOPevEfIFnXQ8PV4pUtawqnqYyM= Original-Received: by 10.48.240.7 with SMTP id n7mr74382nfh; Sat, 02 Jul 2005 12:01:13 -0700 (PDT) Original-Received: by 10.48.250.5 with HTTP; Sat, 2 Jul 2005 12:01:13 -0700 (PDT) Original-To: Emacs Devel In-Reply-To: Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40137 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40137 While still on Occur, another little issue: the documentation of `occur-rename-buffer' talks about adding it to `occur-mode-hook' (it used to say to add it to `occur-hook', but that was a mistake I did when originally adding `occur-hook' and it's now fixed). So, I've been thinking of adding an INTERACTIVE-P argument to `occur-rename-buffer' so it could be used in `occur-mode-hook' as is, instead of (add-hook 'occur-mode-hook #'(lambda () (occur-rename-buffer t))) The main reason is that then `occur-rename-buffer' can be added to `occur-mode-hook' via Customize, which is not an unreasonable thing to expect from any user who reads the `occur-rename-buffer' docstring. --=20 /L/e/k/t/u Index: lisp/replace.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvsroot/emacs/emacs/lisp/replace.el,v retrieving revision 1.216 diff -r1.216 replace.el 924c924 < (defun occur-rename-buffer (&optional unique-p) --- > (defun occur-rename-buffer (&optional unique-p interactive-p) 931c931 < (interactive "P") --- > (interactive "P\np") 938c938 < unique-p))) --- > (or unique-p (not interactive-p)))))