From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#63344: 29.0.90; (shr-zoom-image) doesn't zoom to buffer size Date: Thu, 4 Jul 2024 12:30:20 -0700 Message-ID: References: <87jzxk39zi.fsf@codeisgreat.org> <83sfc8eblo.fsf@gnu.org> <87fs882typ.fsf@codeisgreat.org> <83ednse117.fsf@gnu.org> <87r0rre7ix.fsf@codeisgreat.org> <83mt2fcb04.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28723"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63344@debbugs.gnu.org To: Eli Zaretskii , Pankaj Jangid , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 21:32:40 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPSC5-0007Kl-IL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 21:32:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPSBd-0002En-0a; Thu, 04 Jul 2024 15:32:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPSBY-0002EO-8R for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 15:32:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPSBT-0000uZ-DY for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 15:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPSBV-0003Dt-To for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 15:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63344 X-GNU-PR-Package: emacs Original-Received: via spool by 63344-submit@debbugs.gnu.org id=B63344.172012149112337 (code B ref 63344); Thu, 04 Jul 2024 19:32:01 +0000 Original-Received: (at 63344) by debbugs.gnu.org; 4 Jul 2024 19:31:31 +0000 Original-Received: from localhost ([127.0.0.1]:43022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPSB1-0003Cv-It for submit@debbugs.gnu.org; Thu, 04 Jul 2024 15:31:31 -0400 Original-Received: from mail-pf1-f171.google.com ([209.85.210.171]:53409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPSB0-0003Cd-Bc; Thu, 04 Jul 2024 15:31:30 -0400 Original-Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7065a2f4573so663644b3a.2; Thu, 04 Jul 2024 12:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720121422; x=1720726222; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=1H2z+NTF3UPqxbtXJd0C0E4jF+EFfoh+B2uGHiiGLco=; b=Qm3OBKitduNAy35aJIxo6CI+G+GeSdEg2hCBUF18cuichUJBvJ1nixeshUtvxBYp1j HXStqW4Veg2XRvzBPIDQkupZaW/6C4WHg3oqT2Q1GnUUVawcuizmTxZgDzZ+rQr+SD6W 72+/7/tVgxByXI3hL0TyoAaavSlOVtRxQF1a7D95tCvQaPd1CpUAeDYxsvTFaKk39z3I v0B9PKbSdEtUf66O77ZQK57oHgLRbwTVZqtqwnzuk1jO3u3hEBFWV2RYd2awnTV68//Q iUJT+YMkMhdq6uWXgEcf49wMKib8Gg8myil4Nf3CktdZQ9/bwcmjr0osXOTpF5dRYNjo D2xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720121422; x=1720726222; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1H2z+NTF3UPqxbtXJd0C0E4jF+EFfoh+B2uGHiiGLco=; b=PppPTq3roKwOt0V03PHaBCnP7WAu4+v3q8P3rja7FezH6UkUMR07BV2wYY4dzJjQ5X DXFUV5NPghayZ6Khp1olFoXKs27rqdBrQNaWoi5Cbvrkc3nvMD8lugYOWArQbJ6YsJMG Auc2v10YRpHcEdo/7Cng6Dg663GZGR8x575qVtiQqEpkq7doSA0tsMaQT4uUSxoyyQhD sG3t4Kyl3R2CyV2Pkzs+ehkO2nR3wbTF2BXPYGjwjvF3AljT1e6BSVSesLc7DLbZ9L/4 S38cerFLEHOZMXToBzzqZ5wKgHez1FgnODMFdpn8pNZEXMJ7NyhUO8CpCOnNWmJQZT20 GgbQ== X-Forwarded-Encrypted: i=1; AJvYcCVx6CiyZ+U/X7kM/vijvdila7OfNfyPK3dfzYKWve+ZT+XX3Ps7pLGO0pYrwPk2N/ptJKG5jsOJRe6AvISqCxZlRNbFlRtaVQ== X-Gm-Message-State: AOJu0YzgOgT1d85rniKCoFZXlgiPfVE7tV7TMaYv3S/qN0hZriqNLfY8 gL2IWMJq26/I1FWU51HATSdBcu6EwywQZSw2yHlP3300choN2TDa X-Google-Smtp-Source: AGHT+IELNKvQR1i6ZE2FsmeTYjcOqGmelWFAe6O2xmCr1dCTu3NleJSMpablDmGCv5iZw9hGEmk6zQ== X-Received: by 2002:a05:6a21:99a6:b0:1bd:2520:1fa5 with SMTP id adf61e73a8af0-1c0cc727effmr2839795637.4.1720121421766; Thu, 04 Jul 2024 12:30:21 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2c99a93e499sm1927458a91.2.2024.07.04.12.30.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 12:30:21 -0700 (PDT) Content-Language: en-US In-Reply-To: <83mt2fcb04.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288397 Archived-At: forcemerge 71666 63344 thanks On 5/8/2023 4:34 AM, Eli Zaretskii wrote: > "Full buffer size" wrt an image is confusing in any case (an Emacs > buffer has no "dimensions"), but my reading of the code is that it is > interpreted as the window dimensions, unless the original size is > smaller than that. Not sure if I'm right, though. In bug#71666, I did some archaeology on the Gnus commit history to figure out what this was, and found that the "full buffer size" meant "rescale the image to the height of the window". Over in that bug, I've fixed the issue described here as well as improving the wording in the docstrings to be more precise.